Fix: prevent duplicate new chats and add delete confirmation - #25
Open
darshacharya wants to merge 2 commits into
Open
Fix: prevent duplicate new chats and add delete confirmation#25darshacharya wants to merge 2 commits into
darshacharya wants to merge 2 commits into
Conversation
added 2 commits
February 26, 2026 13:57
- Reuse existing empty chat instead of creating duplicates on repeated "New Chat" clicks - Show confirmation dialog before deleting a chat Made-with: Cursor
- Add Radix UI AlertDialog component matching the app's dark theme - Replace window.confirm() with a proper modal featuring "Delete" and "Cancel" buttons - Adds @radix-ui/react-alert-dialog dependency Made-with: Cursor
Author
|
Hey @karankraina @NP-compete @Anish701 — requesting a review on this PR when you get a chance. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AlertDialog(Radix UI) is now shown before deleting a chat, preventing accidental deletions.Changes
src/frontend/contexts/ChatContext.tsx—createNewChatchecks for an existing empty chat before creating a new onesrc/frontend/components/layout/AppLayout.tsx—handleDeleteChatopens a confirmation dialog instead of deleting immediatelysrc/frontend/components/ui/alert-dialog.tsx— New Radix UI alert dialog component styled for the dark themepackage.json— Added@radix-ui/react-alert-dialogdependencyTest plan