Skip to content

feat: add support for deleting chats - #82

Draft
adranjan4 wants to merge 2 commits into
redhat-data-and-ai:deep-agentfrom
adranjan4:feat/delete-chats-deep-agent
Draft

feat: add support for deleting chats#82
adranjan4 wants to merge 2 commits into
redhat-data-and-ai:deep-agentfrom
adranjan4:feat/delete-chats-deep-agent

Conversation

@adranjan4

@adranjan4 adranjan4 commented Jul 16, 2026

Copy link
Copy Markdown

Summary

  • Add confirmation dialogs for deleting a single chat and clearing all chats
  • Add multi-select mode so users can choose and delete specific chats
  • Persist deleted thread IDs so chats do not reappear after reload if backend sync races
  • Reuses existing Redux + deleteThread API already on deep-agent

Closes #12
Supersedes #66 (that PR targeted main)

Test plan

  • Hover a chat and click delete — confirmation appears
  • Cancel delete — chat remains
  • Confirm delete — chat is removed from sidebar
  • Delete the active chat — navigates to another chat or home
  • Click Select — checkboxes appear; select multiple chats and Delete
  • Cancel selection mode — returns to normal sidebar
  • Click Clear all — confirmation shows chat count; confirm removes all and navigates home
  • Refresh page — deleted chats stay deleted

@adranjan4
adranjan4 force-pushed the feat/delete-chats-deep-agent branch from c2d04cc to 6fd9cd7 Compare July 16, 2026 11:51
@adranjan4
adranjan4 requested a review from a team as a code owner July 22, 2026 11:14
Wire Clear all with confirmation, and persist deleted thread IDs so
chats do not reappear after reload when backend delete fails.

Signed-off-by: adranjan4 <adranjan@redhat.com>
Allow selecting multiple chats and deleting them with confirmation, reusing the existing delete/tombstone flow on deep-agent.

Signed-off-by: adranjan4 <adranjan@redhat.com>
@adranjan4
adranjan4 force-pushed the feat/delete-chats-deep-agent branch from 2819c22 to 98cabf9 Compare July 22, 2026 11:42
@adranjan4 adranjan4 changed the title Support for deleting chats (deep-agent) feat: add support for deleting chats Jul 23, 2026
@adranjan4 adranjan4 changed the title feat: add support for deleting chats add support for deleting chats Jul 23, 2026
@adranjan4 adranjan4 changed the title add support for deleting chats feat: add support for deleting chats Jul 23, 2026
@NP-compete NP-compete linked an issue Jul 27, 2026 that may be closed by this pull request
@NP-compete

Copy link
Copy Markdown
Member

The current template agent does not support this feature.

@adranjan4

Copy link
Copy Markdown
Author

Thanks for linking #12 - could you also assign me to it so the Check Issue Link CI can pass?

On the agent point: understood. This PR is UI-only and reuses deleteThread (DELETE /threads/{id}) plus a localStorage fallback so deleted chats don’t reappear in the sidebar. If template-agent doesn’t implement thread delete yet, server-side deletion won’t fully work.

Happy to follow your preference:

  1. Keep this as UI soft-delete for now (sidebar + local persistence), or
  2. I can open a companion PR on template-agent to add delete-thread support and wire this UI to it.

Which would you prefer?

@NP-compete

Copy link
Copy Markdown
Member

Thanks for linking #12 - could you also assign me to it so the Check Issue Link CI can pass?

On the agent point: understood. This PR is UI-only and reuses deleteThread (DELETE /threads/{id}) plus a localStorage fallback so deleted chats don’t reappear in the sidebar. If template-agent doesn’t implement thread delete yet, server-side deletion won’t fully work.

Happy to follow your preference:

  1. Keep this as UI soft-delete for now (sidebar + local persistence), or
  2. I can open a companion PR on template-agent to add delete-thread support and wire this UI to it.

Which would you prefer?

Lets create the companion PR, and in the meanwhile please change the PR to draft state.

@adranjan4
adranjan4 marked this pull request as draft July 29, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for deleting chats

2 participants