Controller dep bump - #229
Conversation
gshikhar2021
commented
May 25, 2026
gshikhar2021
commented
- Upgraded controller runtime from 0.23.3 to 0.24.1
- Fix: Deprecated package and golangci linting
- Upgraded controller runtime from 0.23.3 to 0.24.1
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Kubernetes API scheme registration by consolidating individual CRD registrations from separate _types.go files into a centralized addKnownTypes function within api/v1alpha1/groupversion_info.go. Additionally, the Go runtime is upgraded to version 1.26.0, and several dependencies are updated, including Kubernetes packages to v0.36.0, controller-runtime to v0.24.1, and OpenTelemetry and Zap logging libraries. No review comments were provided, so there is no feedback to address.
|
also should we update all comments mentioning old version like this https://github.com/redhat-data-and-ai/unstructured-data-controller/blob/main/cmd/main.go#L141 |
|
and along with this, should we bump operator-sdk, kubebuilder etc versions too |
4ec8909 to
d283a34
Compare
|
@concaf MR looks good to me, if you want to include in 0.7 we can merge, if you want on 0.8 we can hold it |
|
let's see how to handle this in context of operator-sdk / kubebuilder migrations because they have a separate migration guide and support only certain versions of certain libraries like controller-runtime |
3 participants
