Skip to content

Limit size of file to 128 MB - #295

Merged
vinamra28 merged 2 commits into
redhat-data-and-ai:mainfrom
gshikhar2021:limit-file-size
Jul 29, 2026
Merged

Limit size of file to 128 MB#295
vinamra28 merged 2 commits into
redhat-data-and-ai:mainfrom
gshikhar2021:limit-file-size

Conversation

@gshikhar2021

Copy link
Copy Markdown
Contributor
  • Snowflake does not support files greater than 128 MB in stage

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a safety mechanism to prevent the processing of files larger than 128 MB. This change ensures compatibility with Snowflake's external stage limitations by validating file sizes before storage operations for both S3 and Google Drive data sources.

Highlights

  • File Size Limitation: Introduced a hard limit of 128 MB for files processed from S3 and Google Drive sources to comply with Snowflake external stage constraints.
  • Logging and Skipping: Added logic to log and skip files that exceed the 128 MB threshold during the synchronization and export processes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a 128 MB file size limit for S3 and Google Drive sources to prevent processing oversized files. While the S3 implementation checks the file size metadata upfront, the Google Drive implementation reads the entire file into memory before checking its size, posing an Out-of-Memory (OOM) risk. It is recommended to use io.LimitReader to safely restrict memory usage and to ensure robust cleanup of stale files that might grow beyond the limit.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pkg/unstructured/source.go
Comment thread pkg/unstructured/source.go Outdated
Comment thread pkg/unstructured/source.go Outdated
Comment thread pkg/unstructured/source.go Outdated
Comment thread pkg/unstructured/source.go
Comment thread pkg/unstructured/source.go
Shikhar Gupta added 2 commits July 27, 2026 11:36
- Snowflake does not support files greater than 128 MB in stage
@vinamra28
vinamra28 merged commit 7abca92 into redhat-data-and-ai:main Jul 29, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants