-
Notifications
You must be signed in to change notification settings - Fork 30
Data 4950 - Atlan backend addition to Usernaut #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Pujathacker2210
wants to merge
11
commits into
redhat-data-and-ai:main
Choose a base branch
from
Pujathacker2210:DATA-4950
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
55439d3
Adding Atlan backend to Usernaut
Pujathacker2210 ce2cc07
Atlan: added OAuth support for user deletion & rebased to handle grou…
Pujathacker2210 344da4f
Atlan: added pagination support for FetchTeamMembersByTeamID function
Pujathacker2210 86aee7e
Atlan: fixed lint issues
Pujathacker2210 466aa49
Update oauth.go to incorporate comments
ruagrawa 1a0bec9
Incorporated comments
ruagrawa fab0fc6
Fix vendor inconsistency for atlan-go dependency
ruagrawa c080171
Removed groupname from function
ruagrawa 827e61e
Fix Atlan persona assignment and add pagination to FetchAllTeams
ruagrawa e4e2d3a
Refactor ReconcileGroupParams to avoid changing other backends
ruagrawa cf1830f
Update mock client to match refactored interface
ruagrawa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -101,6 +101,28 @@ backends: | |
| url: "https://gitlab.test.com" | ||
| token: file|/path/to/gitlab_token | ||
| parent_group_id: 111111 | ||
| - name: atlan | ||
| type: "atlan" | ||
| enabled: true | ||
| depends_on: | ||
| name: "rover" | ||
| type: "rover" | ||
| connection: | ||
| url: "https://yourcompany.atlan.com" | ||
| api_token: file|path/to/atlan_api_token | ||
| # Alias given during setting up identity_provider in the application | ||
| identity_provider_alias: "saml|azure" | ||
| # Username to transfer asset ownership to when deleting a user (required for user deletion) | ||
| asset_transfer_username: "service-account-username" | ||
| # Set to true if users are auto-created via SSO login (skip manual user creation) | ||
| sso_sync: true | ||
| # Default persona to assign all groups | ||
| default_persona: "prod" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we should have default as prod, it should be literally a default one which has no permission, only add users, and not prod, because we are always giving prod persona even if not needed. |
||
| # OAuth credentials for user deletion (required - API tokens don't work for deletion) | ||
| oauth_client_id: file|path/to/atlan_oauth_client_id | ||
| oauth_client_secret: file|path/to/atlan_oauth_client_secret | ||
| # Number of records to fetch per API request for pagination (default: 100) | ||
| pagination_limit: 100 | ||
|
|
||
| apiServer: | ||
| address: "0.0.0.0:8080" | ||
|
|
@@ -119,4 +141,3 @@ offboardUserExclusionListConfigPath: "default_offboard_user_exclusion_list" | |
| # Controller configuration | ||
| controllerConfig: | ||
| maxConcurrentReconciles: 1 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "saml|azure" a place holder? What is thwe actual value this is should have.