Skip to content

feat: watch and reconcile updates to the admin clusterrole #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chetan-rns
Copy link
Member

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:

Currently, we copy the rules from the admin cluster role when creating the application controller role. However, any updates to the admin cluster role are not synced to the application controller cluster role. So, the application controller may not have permissions to manage certain resources until the next reconciliation cycle.

Dependent on: argoproj-labs/argocd-operator#1775

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes https://issues.redhat.com/browse/GITOPS-6367

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

  1. Run the operator
  2. Create a namespace with the managed-by label
  3. Install any operator or aggregate any CRDs to the admin cluster role
  4. Observe if the application controller role is updated to manage the new CRDs

Copy link

openshift-ci bot commented Jul 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Jul 7, 2025
Copy link

openshift-ci bot commented Jul 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chetan-rns for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant