Skip to content

Upgrade Argo CD to v3 in GitOps operator #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jul 24, 2025
Merged

Upgrade Argo CD to v3 in GitOps operator #918

merged 20 commits into from
Jul 24, 2025

Conversation

nmirasch
Copy link
Contributor

@nmirasch nmirasch commented Jul 9, 2025

What type of PR is this?
Upgrade Argo CD to v3 in GitOps operator.
Bring the latest argoproj-labs/argocd-operator@e1f05cb commit to gitops

@openshift-ci openshift-ci bot requested review from anandrkskd and varshab1210 July 9, 2025 16:34
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 9, 2025

Hi @nmirasch. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nmirasch nmirasch marked this pull request as draft July 9, 2025 16:34
@svghadi
Copy link
Member

svghadi commented Jul 10, 2025

/ok-to-test

@svghadi
Copy link
Member

svghadi commented Jul 10, 2025

/ok-to-test

1 similar comment
@svghadi
Copy link
Member

svghadi commented Jul 10, 2025

/ok-to-test

@nmirasch nmirasch marked this pull request as ready for review July 10, 2025 09:09
@openshift-ci openshift-ci bot requested a review from jgwest July 10, 2025 09:10
@aali309 aali309 mentioned this pull request Jul 10, 2025
Closed
4 tasks
@svghadi
Copy link
Member

svghadi commented Jul 11, 2025

/retest

1 similar comment
@svghadi
Copy link
Member

svghadi commented Jul 12, 2025

/retest

@nmirasch nmirasch force-pushed the update_argocd_version_to_v3.0.9 branch from 8328262 to 64e7fbc Compare July 14, 2025 07:15
@Rizwana777 Rizwana777 mentioned this pull request Jul 18, 2025
Open
@varshab1210 varshab1210 force-pushed the update_argocd_version_to_v3.0.9 branch from 86d7b91 to 17fc5e6 Compare July 23, 2025 07:15
@nmirasch nmirasch force-pushed the update_argocd_version_to_v3.0.9 branch from 17fc5e6 to 467589e Compare July 23, 2025 07:54
@svghadi
Copy link
Member

svghadi commented Jul 23, 2025

/retest

svghadi
svghadi approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jul 24, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svghadi svghadi mentioned this pull request Jul 24, 2025
Closed
4 tasks
@svghadi svghadi closed this Jul 24, 2025
@svghadi svghadi reopened this Jul 24, 2025
@svghadi
Copy link
Member

svghadi commented Jul 24, 2025

/ok-to-test

nmirasch and others added 20 commits July 24, 2025 17:16
@nmirasch @svghadi
Upgrade Argo CD to v3 in GitOps operator
d259e81 
Signed-off-by: nmirasch <[email protected]>
@svghadi
Update CRDs
bfb58ed 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Update golang to 1.24 in CI
a632aa8 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Try brew image
1aeff03 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Use mirrored image
2ceebdc 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Add root user to dockerfiles
0fbec8e 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Use different image'
fccd277 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Revert "Add root user to dockerfiles"
b318e76 
This reverts commit 34ac4b3.
@svghadi
Revert ci-operator changes
701848b 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Use SkipNameValidation to avoid controller name validation
55e1662 
With controller-runtime v0.19.0, unique controller name validation is
enforced. The operator fails to start due to this as we don't have unique
names. Use SkipNameValidation to ingnore the uniquness check and prevent panic.

Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Try rhel9 image
f2849c7 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Update operator to latest commit
78c5842 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Try new golang image
16b6ca7 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Update ci operator
de83855 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Fix rollouts upgrade hack go.sum
bd4a3d9 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@varshab1210 @svghadi
add ginkgo test changes
70f626e 
Signed-off-by: Varsha B <[email protected]>
@svghadi
Fix vendoring
d869dba 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Update base image
6289f88 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
fix old e2e tests
ae11c1f 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Update Argo CD to v3.0.11
542ec55 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi svghadi force-pushed the update_argocd_version_to_v3.0.9 branch from 59afc01 to 542ec55 Compare July 24, 2025 11:46
@svghadi
Copy link
Member

svghadi commented Jul 24, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 24, 2025
@svghadi
Copy link
Member

svghadi commented Jul 24, 2025

/retest

2 similar comments
@svghadi
Copy link
Member

svghadi commented Jul 24, 2025

/retest

@svghadi
Copy link
Member

svghadi commented Jul 24, 2025

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 46c43ce into redhat-developer:master Jul 24, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svghadi svghadi svghadi approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@varshab1210 varshab1210 Awaiting requested review from varshab1210

@jgwest jgwest Awaiting requested review from jgwest

Assignees

@svghadi svghadi

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nmirasch @svghadi @openshift-merge-robot @varshab1210