Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix of argo perms and storage #1

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

cooktheryan
Copy link
Collaborator

@cooktheryan cooktheryan commented Feb 11, 2025

  • Allowing for instructlab admins to define items within argocd
  • Removal of minio from application set
  • additional permissions to manage project and knative assets

@cooktheryan cooktheryan changed the title fix of argo perms and storage WIP: fix of argo perms and storage Feb 11, 2025
@srampal
Copy link
Collaborator

srampal commented Feb 11, 2025

As discussed

  1. Please add a list of the changes in the PR description
  2. Retain the minio application manifests. Take it out of the ApplicationSet only.
  3. Add a note on the required RBAC permissions for the argocd controller service account. What parts are already set in RHOAI by default and what we are additionally adding.

@cooktheryan cooktheryan changed the title WIP: fix of argo perms and storage fix of argo perms and storage Feb 11, 2025
… additional permissions. Use default SC

Signed-off-by: Ryan Cook <[email protected]>
Copy link
Collaborator

@srampal srampal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srampal srampal merged commit ff80f93 into redhat-et:main Feb 12, 2025
@cooktheryan cooktheryan deleted the gp3-remove-3 branch February 12, 2025 18:36
srampal added a commit to srampal/parasol-insurance that referenced this pull request Feb 18, 2025
Latest upstream parasol changes are in main-rhoai-2.13 and later main-rhoai-2.16 and are not merged back into upstream/main. Will revert main from our fork and parallel a similar strategy as upstream by keeping per-release branches in our fork not merged into main to align with upstream approach.

This reverts commit ff80f93, reversing
changes made to e036782.
srampal added a commit that referenced this pull request Feb 18, 2025
Revert "Merge pull request #1 from cooktheryan/gp3-remove-3"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants