forked from rh-aiservices-bu/parasol-insurance
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix of argo perms and storage #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cooktheryan
commented
Feb 11, 2025
•
edited
Loading
edited
- Allowing for instructlab admins to define items within argocd
- Removal of minio from application set
- additional permissions to manage project and knative assets
As discussed
|
srampal
reviewed
Feb 11, 2025
bootstrap/ic-user-projects/create-projects-and-resources-job.yaml
Outdated
Show resolved
Hide resolved
bootstrap/ic-user-projects/tools/check-and-recreate-projects.sh
Outdated
Show resolved
Hide resolved
srampal
reviewed
Feb 11, 2025
… additional permissions. Use default SC Signed-off-by: Ryan Cook <[email protected]>
6c6e020
to
9e910e4
Compare
srampal
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
srampal
added a commit
to srampal/parasol-insurance
that referenced
this pull request
Feb 18, 2025
Latest upstream parasol changes are in main-rhoai-2.13 and later main-rhoai-2.16 and are not merged back into upstream/main. Will revert main from our fork and parallel a similar strategy as upstream by keeping per-release branches in our fork not merged into main to align with upstream approach. This reverts commit ff80f93, reversing changes made to e036782.
srampal
added a commit
that referenced
this pull request
Feb 18, 2025
Revert "Merge pull request #1 from cooktheryan/gp3-remove-3"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.