missing items in the tekton chains application description #11
Conversation
Signed-off-by: Ryan Cook <[email protected]>
| @@ -0,0 +1,47 @@ | |||
| kind: ClusterRole | |||
There was a problem hiding this comment.
Any reson why we chose to put this here? Roles are RBAC which are always scoped to the cluster or cluster resource, even if they are application specific. Usually what we do is create a bundle cluster-scope/bundles that references all the other cluster scoped resources like clusterrolebindings, clusterroles, roles, rolebindings, operatorGroups, subscriptions, etc. We then reference that bundle from either the application overlay or the cluster-scope overlay (which becomes cluster-resources in argocd).
| labels: | ||
| app.kubernetes.io/name: controller | ||
| app.kubernetes.io/component: controller | ||
| app.kubernetes.io/instance: default |
There was a problem hiding this comment.
since instance and part-of labels apply to all files within the base deployment, best practice is to us commonLabels in the kustomize to apply to every file but this is just a style thing.
| @@ -0,0 +1,31 @@ | |||
| kind: Role | |||
There was a problem hiding this comment.
same as before,RBAC is always cluster-scoped should be moved there.
| @@ -0,0 +1,36 @@ | |||
| apiVersion: rbac.authorization.k8s.io/v1 | |||
There was a problem hiding this comment.
RBAC --> cluster-scope
A few items were missing when working with tekton chains