odf_setup: make the task names compatible with dcijunit #651
Conversation
|
from change #651:
|
1 similar comment
|
from change #651:
|
WalkthroughThe update modifies task names within the Changes
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 48s |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
roles/odf_setup/tasks/tests.yml(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Sanity Check (stable-2.9)
- GitHub Check: Sanity Check (stable-2.17)
| @@ -28,7 +28,7 @@ | |||
| - cephrbd_pvc_status.resources != [] | |||
| - cephrbd_pvc_status.resources[0].status.phase == "Bound" | |||
|
|
|||
| - name: Test CephFS PVC | |||
| - name: Test_ CephFS PVC | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Standardize test task name for CephFS PVC
Similar to the RBD task, "Test_ CephFS PVC" should not have a space after the underscore. Use a fully underscore‐separated name to ensure consistent JUnit output:
Proposed diff:
- name: Test_ CephFS PVC
+ name: Test_CephFS_PVC| @@ -1,5 +1,5 @@ | |||
| --- | |||
| - name: Test CephRBD PVC | |||
| - name: Test_ CephRBD PVC | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix task name formatting to remove space after underscore
The current task name uses "Test_ CephRBD PVC", which contains an undesired space after the underscore and may produce inconsistent JUnit test identifiers. Use underscores consistently for all word separators.
Proposed diff:
- name: Test_ CephRBD PVC
+ name: Test_CephRBD_PVC📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Test_ CephRBD PVC | |
| - name: Test_CephRBD_PVC |
| @@ -15,7 +15,7 @@ | |||
| storage: 1Gi | |||
| storageClassName: "{{ ocs_sc_rbd_name }}" | |||
|
|
|||
| - name: Get CephRBD PVC status | |||
| - name: Validate_ CephRBD PVC status | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Normalize validation task name to underscore-separated format
The task name "Validate_ CephRBD PVC status" mixes an underscore with a space and still contains spaces elsewhere. For uniform JUnit-compatible naming, convert all spaces to underscores:
Proposed diff:
- name: Validate_ CephRBD PVC status
+ name: Validate_CephRBD_PVC_status📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Validate_ CephRBD PVC status | |
| - name: Validate_CephRBD_PVC_status |
| @@ -44,7 +44,7 @@ | |||
| storage: 1Gi | |||
| storageClassName: "{{ ocs_sc_cephfs_name }}" | |||
|
|
|||
| - name: Get CephFS PVC status | |||
| - name: Validate_ CephFS PVC status | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Ensure consistency in CephFS PVC validation task name
Rename "Validate_ CephFS PVC status" to an all-underscore format so the JUnit parser will treat it as a single identifier:
Proposed diff:
- name: Validate_ CephFS PVC status
+ name: Validate_CephFS_PVC_status📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Validate_ CephFS PVC status | |
| - name: Validate_CephFS_PVC_status |
SUMMARY
Make sure the tests from odf_setup appear as Junit in DCI.
ISSUE TYPE
Tests
Summary by CodeRabbit