-
Notifications
You must be signed in to change notification settings - Fork 42
Preflight: Get certification grade of containers #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughA sequence of tasks was added to the preflight check container workflow to retrieve the operator image digest and query an external catalog API for certification grade information. These steps are executed after the container run, regardless of its outcome, and include debug outputs for both the digest and certification grade. Changes
Suggested reviewers
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 55s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (2)
roles/preflight/tasks/test_preflight_check_container_one_image.yml (2)
119-122
: Enhance debug output clarityRight now the raw digest is printed without context. It’s helpful to prepend a label and reference the image:
- - name: Debug image digest - ansible.builtin.debug: - msg: "{{ sha.stdout }}" + - name: Debug image digest + ansible.builtin.debug: + msg: "Image digest for {{ current_operator_image }}: {{ sha.stdout }}"🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 122-122: trailing spaces
(trailing-spaces)
118-118
: Remove trailing whitespaceYAML lint reports trailing spaces on these blank lines. Please delete any extra spaces to satisfy the linter.
Also applies to: 122-122, 135-135
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 118-118: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
roles/preflight/tasks/test_preflight_check_container_one_image.yml
(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
roles/preflight/tasks/test_preflight_check_container_one_image.yml
[error] 118-118: trailing spaces
(trailing-spaces)
[error] 122-122: trailing spaces
(trailing-spaces)
[error] 135-135: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Sanity Check (stable-2.9)
- GitHub Check: Sanity Check (stable-2.17)
- name: Get image digest | ||
ansible.builtin.shell: > | ||
set -eo pipefail; | ||
skopeo inspect | ||
{% if partner_creds | length %} | ||
--authfile {{ partner_creds }} | ||
{% else %} | ||
--no-creds | ||
{% endif %} | ||
docker://{{ current_operator_image }} | jq -r '.Digest' | ||
register: sha | ||
retries: 2 | ||
delay: 30 | ||
until: sha is succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the success check in the retry loop
The until: sha is succeeded
test isn’t a valid way to detect a successful shell call. This can cause the task to fail even if skopeo inspect
succeeds. Please use the return code instead:
retries: 2
delay: 30
- until: sha is succeeded
+ until: sha.rc == 0
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- name: Get image digest | |
ansible.builtin.shell: > | |
set -eo pipefail; | |
skopeo inspect | |
{% if partner_creds | length %} | |
--authfile {{ partner_creds }} | |
{% else %} | |
--no-creds | |
{% endif %} | |
docker://{{ current_operator_image }} | jq -r '.Digest' | |
register: sha | |
retries: 2 | |
delay: 30 | |
until: sha is succeeded | |
- name: Get image digest | |
ansible.builtin.shell: > | |
set -eo pipefail; | |
skopeo inspect | |
{% if partner_creds | length %} | |
--authfile {{ partner_creds }} | |
{% else %} | |
--no-creds | |
{% endif %} | |
docker://{{ current_operator_image }} | jq -r '.Digest' | |
register: sha | |
retries: 2 | |
delay: 30 | |
until: sha.rc == 0 |
- name: "Pull cert grade of {{ current_operator_image }}" | ||
vars: | ||
filter_params: "filter=docker_image_digest%3D%3D{{ sha.stdout }}" | ||
ansible.builtin.uri: | ||
url: > | ||
{{ catalog_url }}/images?{{ filter_params }}&page_size=100&page=0 | ||
method: GET | ||
headers: | ||
X-API-KEY: "{{ PYXIS_API_TOKEN }}" | ||
status_code: 200 | ||
timeout: 120 | ||
register: pyxis_grade_status | ||
|
||
- name: "Test_ Preflight: Get cert grade of {{ current_operator_image }}" | ||
debug: | ||
msg: "{{ pyxis_grade_status.json.data[0].freshness_grades[0].grade }}" | ||
when: pyxis_grade_status is defined | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Harden the API call and grade lookup
- Use
params:
instead of manually building the query string to avoid encoding issues. - Guard against empty results before indexing into
json.data
andfreshness_grades
to prevent runtime errors.
- - name: "Pull cert grade of {{ current_operator_image }}"
- vars:
- filter_params: "filter=docker_image_digest%3D%3D{{ sha.stdout }}"
- ansible.builtin.uri:
- url: >
- {{ catalog_url }}/images?{{ filter_params }}&page_size=100&page=0
- method: GET
- headers:
- X-API-KEY: "{{ PYXIS_API_TOKEN }}"
- status_code: 200
- timeout: 120
- register: pyxis_grade_status
-
- - name: "Test_ Preflight: Get cert grade of {{ current_operator_image }}"
- debug:
- msg: "{{ pyxis_grade_status.json.data[0].freshness_grades[0].grade }}"
- when: pyxis_grade_status is defined
+ - name: Pull certification grade for {{ current_operator_image }}
+ ansible.builtin.uri:
+ url: "{{ catalog_url }}/images"
+ method: GET
+ headers:
+ X-API-KEY: "{{ PYXIS_API_TOKEN }}"
+ params:
+ filter: "docker_image_digest=={{ sha.stdout }}"
+ page_size: 100
+ page: 0
+ timeout: 120
+ status_code: 200
+ register: pyxis_grade_status
+
+ - name: Debug certification grade
+ ansible.builtin.debug:
+ msg: "{{ pyxis_grade_status.json.data[0].freshness_grades[0].grade }}"
+ when:
+ - pyxis_grade_status.json.data | length > 0
+ - pyxis_grade_status.json.data[0].freshness_grades | length > 0
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- name: "Pull cert grade of {{ current_operator_image }}" | |
vars: | |
filter_params: "filter=docker_image_digest%3D%3D{{ sha.stdout }}" | |
ansible.builtin.uri: | |
url: > | |
{{ catalog_url }}/images?{{ filter_params }}&page_size=100&page=0 | |
method: GET | |
headers: | |
X-API-KEY: "{{ PYXIS_API_TOKEN }}" | |
status_code: 200 | |
timeout: 120 | |
register: pyxis_grade_status | |
- name: "Test_ Preflight: Get cert grade of {{ current_operator_image }}" | |
debug: | |
msg: "{{ pyxis_grade_status.json.data[0].freshness_grades[0].grade }}" | |
when: pyxis_grade_status is defined | |
- name: Pull certification grade for {{ current_operator_image }} | |
ansible.builtin.uri: | |
url: "{{ catalog_url }}/images" | |
method: GET | |
headers: | |
X-API-KEY: "{{ PYXIS_API_TOKEN }}" | |
params: | |
filter: "docker_image_digest=={{ sha.stdout }}" | |
page_size: 100 | |
page: 0 | |
timeout: 120 | |
status_code: 200 | |
register: pyxis_grade_status | |
- name: Debug certification grade | |
ansible.builtin.debug: | |
msg: "{{ pyxis_grade_status.json.data[0].freshness_grades[0].grade }}" | |
when: | |
- pyxis_grade_status.json.data | length > 0 | |
- pyxis_grade_status.json.data[0].freshness_grades | length > 0 |
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 135-135: trailing spaces
(trailing-spaces)
6d45c8f
to
3d1b0e5
Compare
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 53s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (3)
roles/preflight/tasks/test_preflight_check_container_one_image.yml (3)
104-117
: Fix the success check in the retry loop
Theuntil: sha is succeeded
condition doesn’t actually check the command’s return code, so the loop may never exit even whenskopeo inspect
succeeds. Please update it to testsha.rc == 0
.retries: 2 delay: 30 - until: sha is succeeded + until: sha.rc == 0
123-134
: Harden the API call and grade lookup
Rather than manually building the query string, useparams:
to handle encoding, and guard against empty responses before indexing. For example:- - name: "Pull cert grade of {{ current_operator_image }}" - vars: - filter_params: "filter=docker_image_digest%3D%3D{{ sha.stdout }}" - ansible.builtin.uri: - url: "{{ catalog_url }}/images?{{ filter_params }}&page_size=100&page=0" - method: GET - headers: - X-API-KEY: "{{ lookup('file', pyxis_apikey_path) }}" - timeout: 120 - status_code: 200 - register: pyxis_grade_status + - name: Pull certification grade for {{ current_operator_image }} + ansible.builtin.uri: + url: "{{ catalog_url }}/images" + method: GET + headers: + X-API-KEY: "{{ lookup('file', pyxis_apikey_path) }}" + params: + filter: "docker_image_digest=={{ sha.stdout }}" + page_size: 100 + page: 0 + timeout: 120 + status_code: 200 + register: pyxis_grade_status
136-139
: Guard against empty API response before indexing
Accessingjson.data[0].freshness_grades[0]
without checks can error out if the list is empty. Add conditions:- - name: "Test_ Preflight: Get cert grade of {{ current_operator_image }}" - debug: - msg: "{{ pyxis_grade_status.json.data[0].freshness_grades[0].grade }}" - when: pyxis_grade_status is defined + - name: Debug certification grade + ansible.builtin.debug: + msg: "{{ pyxis_grade_status.json.data[0].freshness_grades[0].grade }}" + when: + - pyxis_grade_status.json.data | length > 0 + - pyxis_grade_status.json.data[0].freshness_grades | length > 0
🧹 Nitpick comments (1)
roles/preflight/tasks/test_preflight_check_container_one_image.yml (1)
118-118
: Remove trailing whitespace
YAMLLint flags trailing spaces on these lines. Please strip them to keep the playbook clean.Also applies to: 122-122, 135-135
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 118-118: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
roles/preflight/tasks/test_preflight_check_container_one_image.yml
(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
roles/preflight/tasks/test_preflight_check_container_one_image.yml
[error] 118-118: trailing spaces
(trailing-spaces)
[error] 122-122: trailing spaces
(trailing-spaces)
[error] 135-135: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Sanity Check (stable-2.9)
- GitHub Check: Sanity Check (stable-2.17)
🔇 Additional comments (1)
roles/preflight/tasks/test_preflight_check_container_one_image.yml (1)
119-122
: Debug image digest
Thisansible.builtin.debug
task correctly logs the image digest for troubleshooting.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 122-122: trailing spaces
(trailing-spaces)
from change #673: |
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 49s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (3)
roles/preflight/tasks/test_preflight_check_container_one_image.yml (3)
123-135
: Harden API call and useparams
Building the query string manually can lead to encoding issues, and there’s a blank line at line 135 with trailing whitespace. Useparams:
for cleaner construction and drop the extra vars:- - name: "Pull cert grade of {{ current_operator_image }}" - vars: - filter_params: "filter=docker_image_digest%3D%3D{{ sha.stdout }}" - ansible.builtin.uri: - url: > - {{ catalog_url }}/images?{{ filter_params }}&page_size=100&page=0 - method: GET - headers: - X-API-KEY: "{{ lookup('file', pyxis_apikey_path) }}" - status_code: 200 - timeout: 120 - register: pyxis_grade_status + - name: "Pull certification grade for {{ current_operator_image }}" + ansible.builtin.uri: + url: "{{ catalog_url }}/images" + method: GET + headers: + X-API-KEY: "{{ lookup('file', pyxis_apikey_path) }}" + params: + filter: "docker_image_digest=={{ sha.stdout }}" + page_size: 100 + page: 0 + status_code: 200 + timeout: 120 + register: pyxis_grade_status🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 135-135: trailing spaces
(trailing-spaces)
136-142
: Improve debug guard and naming
This debug task may error if the lists are empty, and the"Test_"
prefix is inconsistent. Combine both fixes:- - name: "Test_ Preflight: Get cert grade of {{ current_operator_image }}" - debug: - msg: "{{ pyxis_grade_status.json.data[0].freshness_grades[0].grade }}" - when: - - pyxis_grade_status is defined - - pyxis_grade_status.json.data[0].freshness_grades[0] is defined + - name: "Debug certification grade for {{ current_operator_image }}" + ansible.builtin.debug: + msg: "{{ pyxis_grade_status.json.data[0].freshness_grades[0].grade }}" + when: + - pyxis_grade_status.json.data | length > 0 + - pyxis_grade_status.json.data[0].freshness_grades | length > 0Also remove trailing whitespace on line 139.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 139-139: trailing spaces
(trailing-spaces)
104-118
: 🛠️ Refactor suggestionFix the retry loop success condition
Usinguntil: sha is succeeded
will never detect a successful command. You should check the return code instead and remove the trailing space on line 118.
Apply this diff:- until: sha is succeeded + until: sha.rc == 0🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 118-118: trailing spaces
(trailing-spaces)
🧹 Nitpick comments (1)
roles/preflight/tasks/test_preflight_check_container_one_image.yml (1)
119-122
: Remove trailing whitespace
Line 122 contains trailing spaces, which causes a YAML lint error. Please remove them.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 122-122: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
roles/preflight/tasks/test_preflight_check_container_one_image.yml
(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
roles/preflight/tasks/test_preflight_check_container_one_image.yml
[error] 118-118: trailing spaces
(trailing-spaces)
[error] 122-122: trailing spaces
(trailing-spaces)
[error] 135-135: trailing spaces
(trailing-spaces)
[error] 139-139: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Sanity Check (stable-2.17)
- GitHub Check: Sanity Check (stable-2.9)
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 51s |
from change #673: |
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 50s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (3)
roles/preflight/tasks/test_preflight_check_container_one_image.yml (3)
104-117
:⚠️ Potential issueFix retry loop success condition
Theuntil: sha is succeeded
check won’t correctly detect a successful shell command. Use the return code instead (sha.rc == 0
) so retries trigger on actual failures.
Apply this diff:- retries: 2 - delay: 30 - until: sha is succeeded + retries: 2 + delay: 30 + until: sha.rc == 0
123-136
: 🛠️ Refactor suggestionUse
params
instead of manual query-string
Building the URL by hand risks encoding problems and reduced readability. Switch to theparams:
option on theuri
module and drop thefilter_params
var. For example:- - name: "Pull cert grade of {{ current_operator_image }}" - vars: - filter_params: "filter=docker_image_digest%3D%3D{{ sha.stdout }}" - ansible.builtin.uri: - url: > - {{ catalog_url }}/images?{{ filter_params }}&page_size=100&page=0 + - name: Pull certification grade for {{ current_operator_image }} + ansible.builtin.uri: + url: "{{ catalog_url }}/images" + method: GET + headers: + X-API-KEY: "{{ lookup('file', pyxis_apikey_path) }}" + params: + filter: "docker_image_digest=={{ sha.stdout }}" + page_size: 100 + page: 0 timeout: 120 status_code: 200 register: pyxis_grade_status when: - cert_project_id | default('') | length🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 135-135: trailing spaces
(trailing-spaces)
138-143
: 🛠️ Refactor suggestionGuard against empty response and trim whitespace
Directly indexing intopyxis_grade_status.json.data[0].freshness_grades[0]
may fail if either list is empty. Also, line 141 has trailing spaces. Consider this safer approach:- - name: "Test_ Preflight: Get cert grade of {{ current_operator_image }}" - debug: - msg: "{{ pyxis_grade_status.json.data[0].freshness_grades[0].grade }}" - when: - - cert_project_id | default('') | length - - pyxis_grade_status.json.data[0] is defined + - name: Debug certification grade for {{ current_operator_image }} + ansible.builtin.debug: + msg: "{{ pyxis_grade_status.json.data[0].freshness_grades[0].grade }}" + when: + - cert_project_id | default('') | length > 0 + - pyxis_grade_status.json.data | length > 0 + - pyxis_grade_status.json.data[0].freshness_grades | length > 0🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 141-141: trailing spaces
(trailing-spaces)
🧹 Nitpick comments (1)
roles/preflight/tasks/test_preflight_check_container_one_image.yml (1)
119-122
: Remove trailing whitespace
Line 122 has trailing spaces that trigger lint warnings. Please delete any extra spaces at end of the line to keep YAML lint happy.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 122-122: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
roles/preflight/tasks/test_preflight_check_container_one_image.yml
(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
roles/preflight/tasks/test_preflight_check_container_one_image.yml
[error] 118-118: trailing spaces
(trailing-spaces)
[error] 122-122: trailing spaces
(trailing-spaces)
[error] 135-135: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Sanity Check (stable-2.17)
from change #673: |
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 58s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (3)
roles/preflight/tasks/test_preflight_check_container_one_image.yml (3)
104-118
: Fix success check in retry loop
The conditionuntil: sha is succeeded
won’t catch the shell return code. Please switch to inspectingsha.rc
for a zero exit status.- until: sha is succeeded + until: sha.rc == 0🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 118-118: trailing spaces
(trailing-spaces)
138-143
: 🛠️ Refactor suggestionGuard against empty API responses
Indexing directly intojson.data[0].freshness_grades[0]
can fail if the list is empty. Add length checks to thewhen:
guard to prevent runtime errors.- - name: "Test_ Preflight: Get cert grade of {{ current_operator_image }}" - ansible.builtin.debug: - msg: "{{ pyxis_grade_status.json.data[0].freshness_grades[0].grade }}" - when: - - cert_project_id | default('') | length - - pyxis_grade_status.json.data[0] is defined + - name: "Debug certification grade for {{ current_operator_image }}" + ansible.builtin.debug: + msg: "{{ pyxis_grade_status.json.data[0].freshness_grades[0].grade }}" + when: + - cert_project_id | default('') | length > 0 + - pyxis_grade_status.json.data | length > 0 + - pyxis_grade_status.json.data[0].freshness_grades | length > 0🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 141-141: trailing spaces
(trailing-spaces)
123-136
: 🛠️ Refactor suggestionUse
params
to build the query string
Instead of manually constructingfilter_params
and interpolating into the URL, leverage theparams:
option on theuri
module. This avoids encoding pitfalls and keeps the URL clean.- - name: "Pull cert grade of {{ current_operator_image }}" - vars: - filter_params: "filter=docker_image_digest%3D%3D{{ sha.stdout }}" - ansible.builtin.uri: - url: > - {{ catalog_url }}/images?{{ filter_params }}&page_size=100&page=0 - method: GET - headers: - X-API-KEY: "{{ lookup('file', pyxis_apikey_path) }}" - status_code: 200 - timeout: 120 - register: pyxis_grade_status + - name: "Pull cert grade for {{ current_operator_image }}" + ansible.builtin.uri: + url: "{{ catalog_url }}/images" + method: GET + headers: + X-API-KEY: "{{ lookup('file', pyxis_apikey_path) }}" + params: + filter: "docker_image_digest=={{ sha.stdout }}" + page_size: 100 + page: 0 + timeout: 120 + status_code: 200 + register: pyxis_grade_status🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 135-135: trailing spaces
(trailing-spaces)
🧹 Nitpick comments (1)
roles/preflight/tasks/test_preflight_check_container_one_image.yml (1)
118-118
: Remove trailing whitespace
Several lines (118, 122, 135, 141) have trailing spaces which can trigger YAML lint errors. Please remove the extra spaces at end of lines.Also applies to: 122-122, 135-135, 141-141
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 118-118: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
roles/preflight/tasks/test_preflight_check_container_one_image.yml
(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
roles/preflight/tasks/test_preflight_check_container_one_image.yml
[error] 118-118: trailing spaces
(trailing-spaces)
[error] 122-122: trailing spaces
(trailing-spaces)
[error] 135-135: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Sanity Check (stable-2.9)
- GitHub Check: Sanity Check (stable-2.17)
from change #673: |
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 50s |
from change #673: |
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 56s |
from change #673: |
SUMMARY
Get certification grade of containers after preflight execution
ISSUE TYPE
Tests