check_resource | Remove check for current/desired-state in wait-sriov.yml #701

ramperher · 2025-06-10T08:35:12Z

SUMMARY

It's not true that all the SriovNetworkNodeState checks have the SRIOV annotations present, e.g. https://www.distributed-ci.io/jobs/e655be15-f3ce-410b-8e75-a9476c50d4ae/jobStates?sort=date&task=625d5c02-78c2-4779-b561-2346840feacc, the task is failing because all checks were passing but desired-state annotation was not in place.

From what I've extracted from daily jobs, I could see that:

These two annotations are not present in OCP 4.12
Only "sriovnetwork.openshift.io/current-state" is present from OCP 4.14
"sriovnetwork.openshift.io/desired-state" annotation looks like present from OCP 4.16, since daily jobs with that version and higher ones are passing, e.g. https://www.distributed-ci.io/jobs/724add53-e2bb-4c01-91a9-e41cd305b5ab/jobStates

So, with this change, I'm just returning to the original check, which is just to check the syncStatus, just to be compliant with all available OCP releases. but still using the cleaner approach with json_query, introduced in this PR: #661

It's true that it would be more precise to also use the two network annotations aforementioned, but with the syncStatus it should be fine; typically, syncStatus moves to Succeeded once the annotations (if they're defined) are in Idle status.

ISSUE TYPE

Bug

Tests

Job passed in OCP 4.12 - https://www.distributed-ci.io/jobs/452c8dd6-ad39-4217-b2e5-f9f07f66b7bb/jobStates

Test-Hints: no-check

coderabbitai · 2025-06-10T08:35:19Z

📝 Walkthrough

Walkthrough

The wait-sriov.yml task was simplified by removing the extraction and checks of both "current-state" and "desired-state" annotations from the SriovNetworkNodeState resource. Now, it only waits for the resource’s sync status to be "Succeeded" and that the resource exists.

Changes

File(s)	Change Summary
roles/check_resource/tasks/wait-sriov.yml	Removed extraction and evaluation of "current-state" and "desired-state" annotations; simplified wait condition to check only sync status and resource existence.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a3c566 and 091ba08.

📒 Files selected for processing (1)

roles/check_resource/tasks/wait-sriov.yml (0 hunks)

💤 Files with no reviewable changes (1)

roles/check_resource/tasks/wait-sriov.yml

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Sanity Check (stable-2.18)
GitHub Check: Sanity Check (stable-2.9)
GitHub Check: Ansible-lint Check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

softwarefactory-project-zuul · 2025-06-10T08:38:16Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/5e045db57d844decb2902872b5dc1186

✔️ dci-rpm-build-el8 SUCCESS in 2m 52s
✔️ dci-rpm-build-el9 SUCCESS in 2m 23s

ramperher · 2025-06-10T08:39:28Z

recheck

softwarefactory-project-zuul · 2025-06-10T08:42:32Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/5336a3b605c744a0ab2a996193ddb7c6

✔️ dci-rpm-build-el8 SUCCESS in 2m 51s
✔️ dci-rpm-build-el9 SUCCESS in 2m 17s

dcibot · 2025-06-10T09:28:04Z

from change #701:

ERROR https://www.distributed-ci.io/jobs/280b8f31-e527-4f67-9918-737e5976caba/jobStates

ramperher · 2025-06-10T09:53:03Z

recheck

softwarefactory-project-zuul · 2025-06-10T09:56:04Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/2ccb8786b09e458c996f979983a0ede3

✔️ dci-rpm-build-el8 SUCCESS in 2m 48s
✔️ dci-rpm-build-el9 SUCCESS in 2m 22s

ramperher · 2025-06-10T10:00:44Z

recheck

ramperher · 2025-06-10T10:02:50Z

recheck

softwarefactory-project-zuul · 2025-06-10T10:04:06Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/434a9d458a5a4f4fb225616a890a9540

✔️ dci-rpm-build-el8 SUCCESS in 2m 49s
✔️ dci-rpm-build-el9 SUCCESS in 2m 23s

ramperher · 2025-06-10T10:06:10Z

recheck

softwarefactory-project-zuul · 2025-06-10T10:09:18Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/436caaa2e9924d788c5b7bbc42c97cad

✔️ dci-rpm-build-el8 SUCCESS in 2m 54s
✔️ dci-rpm-build-el9 SUCCESS in 2m 22s

dcibot · 2025-06-10T10:13:06Z

from change #701:

ERROR https://www.distributed-ci.io/jobs/49421e19-6405-4543-9513-e3303f06ac12/jobStates

ramperher · 2025-06-10T11:27:59Z

recheck

softwarefactory-project-zuul · 2025-06-10T11:30:59Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/b28e8ac04ecd4057bcc3ff178f4c550a

✔️ dci-rpm-build-el8 SUCCESS in 2m 48s
✔️ dci-rpm-build-el9 SUCCESS in 2m 22s

manurodriguez · 2025-06-10T12:49:07Z

SUMMARY

It's not true that all the SriovNetworkNodeState checks have the desired-state annotation present, e.g. https://www.distributed-ci.io/jobs/e655be15-f3ce-410b-8e75-a9476c50d4ae/jobStates?sort=date&task=625d5c02-78c2-4779-b561-2346840feacc, the task is failing because all checks were passing but desired-state annotation was not in place. It's enough by checking the current-state and the syncStatus.

Thanks Ramon, I started to experience this yesterday, I suspect SRIOV operator changed.

dcibot · 2025-06-10T14:02:17Z

from change #701:

FAILURE https://www.distributed-ci.io/jobs/b42804a2-2b18-4d11-84a8-44c4dcc99983/jobStates

ramperher · 2025-06-10T16:17:21Z

SUMMARY

It's not true that all the SriovNetworkNodeState checks have the desired-state annotation present, e.g. https://www.distributed-ci.io/jobs/e655be15-f3ce-410b-8e75-a9476c50d4ae/jobStates?sort=date&task=625d5c02-78c2-4779-b561-2346840feacc, the task is failing because all checks were passing but desired-state annotation was not in place. It's enough by checking the current-state and the syncStatus.

Thanks Ramon, I started to experience this yesterday, I suspect SRIOV operator changed.

In fact, I've tested in 4.12 with SPK and it failed because no network annotation is used there to report the "Idle" status, it's just used the syncStatus field, so I've refactored again the code.

softwarefactory-project-zuul · 2025-06-10T16:19:47Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/b637b450b733444d9eea9be6bb43f8ce

✔️ dci-rpm-build-el8 SUCCESS in 2m 54s
✔️ dci-rpm-build-el9 SUCCESS in 2m 17s

dcibot · 2025-06-10T19:05:40Z

from change #701:

SUCCESS https://www.distributed-ci.io/jobs/452c8dd6-ad39-4217-b2e5-f9f07f66b7bb/jobStates

manurodriguez

LGTM

tonyskapunk · 2025-06-10T21:37:35Z

Before merging can we ensure those annotations are really not in use and the failure is not something else?

I found previous jobs without those annotations and it didn't fail, why it is failing now?

2025-06-08

https://www.distributed-ci.io/jobs/15e885af-e946-424d-9e73-d9f5c849ceb9

2025-06-09

https://www.distributed-ci.io/jobs/50ca4910-5d74-460f-a263-b2d4d5cb6f9c

2025-06-03

https://www.distributed-ci.io/jobs/a13a6501-3ea0-4f7c-9125-9707f4439c97

2025-05-25

https://www.distributed-ci.io/jobs/68f08a95-2d23-4d7a-a70e-411b88f5e957

On the other hand I do see the checked annotations in these jobs:

2025-06-09

. It's enough by checking the current-state and the syncStatus.

@ramperher did you find something that confirms the syncstatus is enough?

ramperher · 2025-06-11T08:02:00Z

Before merging can we ensure those annotations are really not in use and the failure is not something else?

I found previous jobs without those annotations and it didn't fail, why it is failing now?

2025-06-08

https://www.distributed-ci.io/jobs/15e885af-e946-424d-9e73-d9f5c849ceb9

2025-06-09

https://www.distributed-ci.io/jobs/50ca4910-5d74-460f-a263-b2d4d5cb6f9c

2025-06-03

https://www.distributed-ci.io/jobs/a13a6501-3ea0-4f7c-9125-9707f4439c97

2025-05-25

https://www.distributed-ci.io/jobs/68f08a95-2d23-4d7a-a70e-411b88f5e957

On the other hand I do see the checked annotations in these jobs:

2025-06-09

https://www.distributed-ci.io/jobs/77ab5213-cc2e-4cb7-9ffb-542fb5406b78

https://www.distributed-ci.io/jobs/d306b4a3-05c0-4a62-a389-30eb0f2afbbe

. It's enough by checking the current-state and the syncStatus.

@ramperher did you find something that confirms the syncstatus is enough?

@tonyskapunk , all the jobs you were quoting were using an older version of wait-sriov playbook from the check_resource role. This changed the 9th of June with my change to document other SRIOV setups for example-cnf, including Mellanox support: ec7cdb6#diff-d4875c737e9f1aa17619dc88fa6d49137f1e474fd6fa4fab763f48eb669d8712

For this, I improved the SriovNetworkNodeState check, to use json_query, and I also included the checks of the annotations called "sriovnetwork.openshift.io/current-state" and "sriovnetwork.openshift.io/desired-state". They were available in the OCP version I was testing example-cnf (OCP 4.18). I wrongly assumed that these annotations were in place in older OCP versions without testing them, my bad.

From what I've extracted from daily jobs, I could see that:

These annotations are not present in OCP 4.12
Only "sriovnetwork.openshift.io/current-state" is present from OCP 4.14
"sriovnetwork.openshift.io/desired-state" annotation looks like present from OCP 4.16, since daily jobs with that version and higher ones are passing, e.g. https://www.distributed-ci.io/jobs/724add53-e2bb-4c01-91a9-e41cd305b5ab/jobStates

So, with this change, I'm just returning to the original check, which is just to check the syncStatus, but still using the cleaner approach with json_query, just to be compliant with all available OCP releases. It's true that it would be more precise to also use the two network annotations aforementioned, but with the syncStatus it should be fine; typically, syncStatus moves to Succeeded once the annotations (if they're defined) are in Idle status.

If you don't mind, I will include this conclusion in the PR description and merge the change.

ramperher requested a review from a team as a code owner June 10, 2025 08:35

check_resource | Remove check for desired-state in wait-sriov.yml

091ba08

ramperher force-pushed the wait-sriov-fix branch from 6a3c566 to 091ba08 Compare June 10, 2025 16:16

manurodriguez approved these changes Jun 10, 2025

View reviewed changes

ramperher changed the title ~~check_resource | Remove check for desired-state in wait-sriov.yml~~ check_resource | Remove check for current/desired-state in wait-sriov.yml Jun 11, 2025

ramperher added this pull request to the merge queue Jun 11, 2025

Merged via the queue into main with commit d48c2b0 Jun 11, 2025
8 checks passed

ramperher deleted the wait-sriov-fix branch June 11, 2025 08:15

check_resource | Remove check for current/desired-state in wait-sriov.yml #701

check_resource | Remove check for current/desired-state in wait-sriov.yml #701

Uh oh!

Conversation

ramperher commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

ISSUE TYPE

Tests

Uh oh!

coderabbitai bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

softwarefactory-project-zuul bot commented Jun 10, 2025

Uh oh!

ramperher commented Jun 10, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 10, 2025

Uh oh!

dcibot commented Jun 10, 2025

Uh oh!

ramperher commented Jun 10, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 10, 2025

Uh oh!

ramperher commented Jun 10, 2025

Uh oh!

ramperher commented Jun 10, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 10, 2025

Uh oh!

ramperher commented Jun 10, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 10, 2025

Uh oh!

dcibot commented Jun 10, 2025

Uh oh!

ramperher commented Jun 10, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 10, 2025

Uh oh!

manurodriguez commented Jun 10, 2025

SUMMARY

Uh oh!

dcibot commented Jun 10, 2025

Uh oh!

ramperher commented Jun 10, 2025

SUMMARY

Uh oh!

softwarefactory-project-zuul bot commented Jun 10, 2025

Uh oh!

dcibot commented Jun 10, 2025

Uh oh!

manurodriguez left a comment

Choose a reason for hiding this comment

Uh oh!

tonyskapunk commented Jun 10, 2025

Uh oh!

ramperher commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ramperher commented Jun 10, 2025 •

edited

Loading

coderabbitai bot commented Jun 10, 2025 •

edited

Loading

ramperher commented Jun 11, 2025 •

edited

Loading