Initial Type hinting: setting things up to gradually enable stricter type hinting #233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Type hinting: setting things up to gradually enable stricter type hinting as part of #229
Notes:
I'd like to slowly flip on the pyright settings set to false to warn/error based on what makes sense as type hinting work continues.
There are two cases where pyright shows an error currently because I didn't want to make a code change and didn't want to relax the rule, both are related to the rule reportUnnecessaryComparison:
*otterwiki/wiki.py L267: commit_count is explicitly set to 100 on line 235 and never changed, so it can never be None
Tests: