Skip to content

RI-6570 Verify generic edit operations in the browsers module #4730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: feature/RI-6570/e2e-playwright-browser-keys-read
Choose a base branch
from

Conversation

valkirilov
Copy link
Collaborator

@valkirilov valkirilov commented Jul 18, 2025

Description

Add new E2E tests to check the generic update functionalities in the Browsers module. These tests make sure that when you click on a key, you can update its name and TTL.

image

How the tests work

  • First, prepare the data for the test using the Redis API (it's easier and faster and also, the UI flow for creating keys is already covered in another test suite)
  • Then we open the Details Panel by clicking on the key we just added (in the table in the UI)
  • After that, we go and update the key name and its TTL

Note: Once PR: 4723 is merged, make sure to update the target branch of this pull request to lead to feature/RI-6570/PlayWright branch.

Code Changes

  • Extend browser page locators to provide helpers for dealing with the state of the keys and their values in details drawer
  • Add e2e tests to verify that you can edit all the information related to the various key types displayed in the details drawer

How to run the tests

You can always refer to the README, but simply running the following command should do the trick for you

# From the root directory
yarn dev:api

# In a new tab, again from the root directory
yarn dev:ui

# In a new tab, but this time go to tests/playwright directory
yarn test:chromium:local-web browser/keys-edit 

# The, check the detailed report an all the video recordings
yarn playwright show-report

Edit (generic)

yarn test:chromium:local-web browser/keys-edit.spec
image

* added e2e test to verify whether the edit key name functionality is working fine in the browser module
* also verify the ttl field and jow it can be updated or cleared

re #RI-6570
Copy link
Contributor

Code Coverage - Backend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 92.34% 13787/14931
🟡 Branches 74% 4147/5604
🟢 Functions 85.82% 2124/2475
🟢 Lines 92.13% 13180/14306

Test suite run success

2941 tests passing in 286 suites.

Report generated by 🧪jest coverage report action from 6f85828

Copy link
Contributor

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 81.37% 18403/22616
🟡 Branches 67% 8068/12042
🟡 Functions 75.14% 4867/6477
🟢 Lines 81.76% 18006/22024

Test suite run success

4792 tests passing in 628 suites.

Report generated by 🧪jest coverage report action from 6f85828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant