-
Notifications
You must be signed in to change notification settings - Fork 385
RI-7197 Introduce vector search actions panel #4741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RI-7197 Introduce vector search actions panel #4741
Conversation
- added simple component to present the different actions on the vector search page - added button for "manage indexet" to open the coresponding drawer - added a placeholder button for "saved queries" drawer re #RI-7197
Code Coverage - Frontend unit tests
Test suite run success4813 tests passing in 635 suites. Report generated by 🧪jest coverage report action from ec372b9 |
|
||
// Workaround for @redis-ui/components Title component issue with react-children-utilities | ||
// TypeError: react_utils.childrenToString is not a function | ||
jest.mock('uiSrc/components/base/layout/drawer', () => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some odd reason, there is a weird issue with the Title
component rendered inside the Drawer's Header
component (provided by Redis UI), causing the rendering of the component to fail.
FAIL redisinsight/ui/src/pages/vector-search/manage-indexes/ManageIndexesDrawer.spec.tsx
ManageIndexesDrawer
✕ should render (58 ms)
● ManageIndexesDrawer › should render
TypeError: react_utils.childrenToString is not a function
184 | const wrapper = !withRouter ? Wrapper : BrowserRouter
185 |
> 186 | return rtlRender(ui, { wrapper, ...renderOptions })
| ^
187 | }
188 |
I have applied the same temporary workaround you already found a while ago (reference)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happened to me as well and mocked the same way for ShortcutsFlyout
|
||
// Workaround for @redis-ui/components Title component issue with react-children-utilities | ||
// TypeError: react_utils.childrenToString is not a function | ||
jest.mock('uiSrc/components/base/layout/drawer', () => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happened to me as well and mocked the same way for ShortcutsFlyout
aa376b0
to
ec372b9
Compare
Description
Introduce a simple Vector Search actions panel that can be later injected in the proper place in the UI:
TextButton
component (docs)Drawer
component docsVector Search actions
Manage Indexes drawer
Note: For now, the content of the drawer is blank, but it will be implemented in a separate pull request

How to test it
These are base components that will be included in the new wizard for the Vector Search, but currently, you can find them integrated on a temporary page, for the sake of testing them.
Simply flip this temporary switch in
redisinsight/ui/src/pages/vector-search/VectorSearchPage.tsx
and then click on the "Search" icon in the left side nav to open the page: