Skip to content

RI-7463 sentinel databases rerender #5126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 183 commits into
base: main
Choose a base branch
from
Open

RI-7463 sentinel databases rerender #5126

wants to merge 183 commits into from
+1,600 −925

Conversation

@pd-redis
Copy link
Collaborator

@pd-redis pd-redis commented Oct 30, 2025 •
edited
Loading

Masters:
image

Result:
image

pd-redis added 30 commits May 7, 2025 12:28
@pd-redis
add redis-ui
d377072
@pd-redis
add forms/button
3a3696b
@pd-redis
run format
ba385ab
@pd-redis
add icons
049a991
@pd-redis
add general export
3c3b65f
@pd-redis
re-export icons from ui-icons
1832c1a
@pd-redis
add theme config in themeContext.tsx
e5ed77b
@pd-redis
make SecondaryButton.tsx outlined by default
8026a6c
@pd-redis
add EmptyButton.tsx
36e23a1
@pd-redis
add key panels
e2a9bfe
@pd-redis
icon button added
f580b98
@pd-redis
edit json icons
192aa1f
@pd-redis
analysis page
e9358e0
@pd-redis
update font size
f1051e2
@pd-redis
DatetimeForm.tsx
31da78e
@pd-redis
CloudSettings.tsx
40cbb55
@pd-redis
add play and play filled icons
75db002
@pd-redis
QueryCardHeader.tsx
52771a4
@pd-redis
QueryActions.tsx
d07d5d2
@pd-redis
InternalPage.tsx
eee47b2
@pd-redis
Merge branch 'main' into fe/feature/RI-7039-replace-eui
aaaa43b 
# Conflicts:
#	redisinsight/ui/src/components/connectivity-error/ConnectivityError.tsx
#	redisinsight/ui/src/components/inline-item-editor/InlineItemEditor.tsx
#	redisinsight/ui/src/components/item-list/components/delete-action/DeleteAction.tsx
#	redisinsight/ui/src/components/item-list/components/export-action/ExportAction.tsx
#	redisinsight/ui/src/components/query/query-actions/QueryActions.tsx
#	redisinsight/ui/src/components/query/query-card/QueryCardHeader/QueryCardHeader.tsx
#	redisinsight/ui/src/components/side-panels/panels/enablement-area/EnablementArea/components/InternalPage/InternalPage.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeyHash/AddKeyHash.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeyList/AddKeyList.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeyReJSON/AddKeyReJSON.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeySet/AddKeySet.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeyStream/AddKeyStream.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeyString/AddKeyString.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeyZset/AddKeyZset.tsx
#	redisinsight/ui/src/pages/browser/modules/key-details/components/rejson-details/components/edit-entire-item-action/EditEntireItemAction.tsx
#	redisinsight/ui/src/pages/browser/modules/key-details/components/set-details/add-set-members/AddSetMembers.tsx
#	redisinsight/ui/src/pages/database-analysis/components/header/Header.tsx
#	redisinsight/ui/src/pages/home/components/database-list-header/DatabaseListHeader.tsx
#	redisinsight/ui/src/pages/home/components/database-manage-tags-modal/ManageTagsModal.tsx
#	redisinsight/ui/src/pages/settings/components/cloud-settings/CloudSettings.tsx
#	redisinsight/ui/src/pages/settings/components/cloud-settings/components/user-api-keys-table/UserApiKeysTable.tsx
#	redisinsight/ui/src/pages/slow-log/components/Actions/Actions.tsx
@pd-redis
move all icon imports
6301a55
@pd-redis
checkpoint
05ef986
@pd-redis
add db dialog
88bfbe9
@pd-redis
notifications
4966145
@pd-redis
remove unused imports
226baf2
@pd-redis
fix ZSetDetails.tsx overflow
1acb93a
@pd-redis
command helper
e836924
@pd-redis
refactor window controls
f744afc
@pd-redis
checkpoint
0f0e74f
dantovska
dantovska reviewed Nov 4, 2025
View reviewed changes
redisinsight/ui/src/components/base/layout/flex/flex.styles.ts
Comment on lines +287 to +292
export type PaddingType =
| keyof typeof flexItemStyles.padding
| null
| undefined
| true
| false
Copy link
Collaborator

@dantovska dantovska Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what would a padding: true mean? why are we allowing this as a value?

Copy link
Collaborator Author

@pd-redis pd-redis Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true === '4', meaning it is the default padding applied if you use <FlexItem padding/>

Copy link
Collaborator Author

@pd-redis pd-redis Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I also think, that this PR is not related to changing layout components, we can and should do this separately

KrumTy
KrumTy reviewed Nov 4, 2025
View reviewed changes
KrumTy
KrumTy reviewed Nov 4, 2025
View reviewed changes
...c/pages/autodiscover-sentinel/sentinel-databases-result/useSentinelDatabasesResultConfig.tsx Outdated
Comment on lines 358 to 360
useEffect(() => {
setTitle('Redis Sentinel Primary Groups Added')
if (!masters.length) {
Copy link
Collaborator

@KrumTy KrumTy Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the title need to change back on component unmount?
overall, quite weird mechanism we have here

@pd-redis pd-redis requested a review from DimoHG as a code owner November 5, 2025 19:49
@pd-redis pd-redis requested review from KrumTy and dantovska November 5, 2025 20:54
KrumTy
KrumTy previously approved these changes Nov 6, 2025
View reviewed changes
Copy link
Collaborator

@KrumTy KrumTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's worth extracting some of the styled components to .styles.ts files, other than that LGTM

@pd-redis
Refactor Sentinel database result columns into separate components
40cd5e7 
- Split column definitions into individual files for better organization
- Updated ResultColumn to fix TypeScript error with onAddInstance type
- Adjusted column properties (minSize to maxSize) for consistency
- Moved handleBackAdding and handleViewDatabases to useCallback hooks
- Updated imports and colFactory to use new component structure
@pd-redis
Refactor Sentinel databases column definitions
b6fe67a 
- Extracted column definitions to separate files
- Updated useSentinelDatabasesConfig.tsx with new structure
dantovska
dantovska previously approved these changes Nov 6, 2025
View reviewed changes
@pd-redis
Enhance Sentinel databases result UI
3bffbf8 
- Created Summary component for result feedback
- Fixed ResultColumn sizing property to minSize
@pd-redis pd-redis deployed to development November 6, 2025 12:24 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KrumTy KrumTy KrumTy approved these changes

@dantovska dantovska dantovska approved these changes

@pawelangelow pawelangelow Awaiting requested review from pawelangelow pawelangelow is a code owner

@ArtemHoruzhenko ArtemHoruzhenko Awaiting requested review from ArtemHoruzhenko ArtemHoruzhenko is a code owner

@valkirilov valkirilov Awaiting requested review from valkirilov valkirilov is a code owner

@DimoHG DimoHG Awaiting requested review from DimoHG DimoHG is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pd-redis @CLAassistant @KrumTy @dantovska