Skip to content

Conversation

@kaitlynmichael
Copy link
Contributor

No description provided.

@jit-ci
Copy link

jit-ci bot commented Sep 26, 2025

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2025

DOC-5497

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2025

@kaitlynmichael kaitlynmichael marked this pull request as ready for review October 15, 2025 15:07
@kaitlynmichael kaitlynmichael requested review from a team and yuvallevy2 October 15, 2025 15:07
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few cosmetic suggestions and checks to consider, but otherwise language LGTM.

@kaitlynmichael
Copy link
Contributor Author

Approved by Ran Dvir via Slack

Copy link
Contributor

@cmilesb cmilesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of these code blocks need to be extended slightly - a chunk of text at the end is being blocked by the copy button on my laptop screen.


Create a policy that grants the Redis Enterprise operator read access to secrets:

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code block and the one below it don't scroll completely to the right on my laptop screen.
Screenshot 2025-11-14 at 14 12 29


Configuration parameters:

| Parameter | Description | Default | Required |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with the table here. You may want to make it a scrollable table.


Generate and store the admission controller TLS certificate in Vault:

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing with this code block and the one after the one below it.
Screenshot 2025-11-14 at 14 12 29

To create a Redis Enterprise database (REDB) with Vault integration:

1. Create database password in Vault:
```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this code block:
Screenshot 2025-11-14 at 14 18 28


You can also update certificates using `kubectl patch`:

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this code block.
Screenshot 2025-11-14 at 14 19 32

#### Backup storage credentials
Store backup storage credentials for Redis Enterprise databases:

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-11-14 at 14 20 21 Same with this one and the one below.


Symptoms: Operator pod remains in `Pending` or `CrashLoopBackOff` state

Causes and solutions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first two code blocks in this section are also not scrollable.

curl -k https://<VAULT_FQDN>:8200/v1/sys/health
```

#### Authentication failures
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with both of these code blocks.


Symptoms: `Failed to read Vault secret` errors

Solutions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these code blocks as well.

vault kv get -format=json -namespace=<VAULT_NAMESPACE> <VAULT_SECRET_ROOT>/redisenterprise-<K8S_NAMESPACE>/<cluster-name>
```

### Debugging commands
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with all of these code blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants