fix: Fixed issue adding Go 1.22.x and 1.23.x and drop Go 1.19.x

[ozennou]

Update Go versions: Add support for Go 1.22.x and 1.23.x in the build.yml workflow, while removing support for the outdated and unsupported Go 1.19.x version. This ensures compatibility with newer Go versions and keeps the build process up-to-date.
#3238

[ndyakov]

Based on https://go.dev/doc/devel/release 1.20.x and 1.21.x are not supported as well. If it is decided to drop support for 1.19, does it make sense for the https://github.com/redis/go-redis/blob/master/go.mod#L3 to be updated as well? It still states 1.18, but if tests are not executed on 1.18 and 1.19, maybe stating 1.20 as min versions should be done.

[ozennou]

Thank you for pointing that out! If support for 1.18 and 1.19 is being dropped, it does make sense to update the go.mod file to reflect 1.20 as the minimum version. I can include this change in the PR or handle it separately—let me know your preference!

[urdarinda]

qq, should this drop support for 1.20 and 1.21 as well?

[ozennou]

qq, should this drop support for 1.20 and 1.21 as well?

True, I think I should add only the 1.22 and 1.23 without dropping 1.19

[urdarinda]

qq, should this drop support for 1.20 and 1.21 as well?

True, I think I should add only the 1.22 and 1.23 without dropping 1.19

What I meant was, we should probably drop support for 1.20 and 1.21 as well. maybe

[ozennou]

Got it, thanks!

[urdarinda]

@ndyakov any plans to merge this one?

[SoulPancake]

Are quotes required here? @ozennou

[ozennou]

No, just a best practice

[ndyakov]

I will get back to you in the following week. Currently I am playing around with the test setup. I ran into some failing tests if we decide to change the go version in the go.mod . For this reason I will postpone the said change for now.

…

On Tue, 28 Jan 2025 at 18:40, mohamed amine ozennou < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In .github/workflows/test-redis-enterprise.yml <#3239 (comment)>: > @@ -15,7 +15,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: [1.21.x] + go-version: ["1.21.x"] No, just a best practice — Reply to this email directly, view it on GitHub <#3239 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALZXMX5VKUZRZJOXCR67Z32M6XIBAVCNFSM6AAAAABVL2NC5CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNZYHA2DONBXGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>