fix: Prioritize TextMarshaler for argument serialization (#3139) #3445
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensures types implementing both TextMarshaler and BinaryMarshaler are marshaled as text. * Also required reordering net.IP case to prevent string conversion due to added case.
* Ensures types implementing both TextMarshaler and BinaryMarshaler are marshaled as text. * Also required reordering net.IP case to prevent string conversion due to added case.
|
Hello @ostheperson and thank you for the contribution. This looks like it should work, but has the possibility to be a breaking change for users that are currently using with a type implemented by both TextMarshaler and BinaryMarshaler. I will label it for the next major version. |
|
understood |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3139