Remove commented out code #3722
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e` module. There is a commented code that invalidates a client connection when the Connection is no longer listening. This patch aims to remove it
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
50-Course
changed the title
src/main/java/redis/clients/jedis/JedisPubSubBase module.src/main/java/redis/clients/jedis/JedisPubSubBase module.
ggivo
changed the title
src/main/java/redis/clients/jedis/JedisPubSubBase module.
ggivo
added
skip-changelog
|
Clean up PR's. Removes 2 lines of commented-out code. Let's leave them for now as a hint till we review if they are actually needed, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a commented code meant to initially invalidate
clientconnection when the Connection is no longer listening.However, it is currently being bypassed, and does not actually reference anything in the JVM.
This patch aims to remove it - therefore, and as such does not introduces breaking change to the actual module.