Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-4757 list async examples #3146

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Jan 28, 2025

Make sure that:

  • You have read the contribution guidelines.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

DOC-4757

Couple of things to note:

  • I've used exceptionally() in the rule_1.1 example to handle the exception that it demonstrates. Is this best approach? There seem to be a few ways to handle exceptions with CompletableFuture.
  • I've hidden the del() commands at the start of some of the examples because they are hidden in the examples for the other clients/languages. However, would it be better to actually show the del() calls for Lettuce, given that the CompletableFuture instances are chained together? In some examples, the first line basically tells you the name of the previous example in the chain, so would readers assume that the new example starts with the same DB state that the previous one ended with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant