-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Lettuce test setup to use client-lib-test #3158
Migrate Lettuce test setup to use client-lib-test #3158
Conversation
24693f5
to
b9dceb8
Compare
1f6b443
to
c4e3b08
Compare
e79ac3f
to
7892951
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self review, so our sync-up today goes faster. (after discussion with Ivo)
src/test/resources/docker-env/redis-standalone-0/config/node-6478/redis.conf
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
src/test/java/io/lettuce/core/commands/RunOnlyOnceServerCommandIntegrationTests.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Make sure that:
mvn formatter:format
target. Don’t submit any formatting related changes.This change removes the old way of deploying redis on make and your machine and uses docker containers.
https://github.com/redis-developer/cae-client-testing/tree/main/docker/client-libs-test-container
Its part of the ongoing effort to unify and tidy up the testing of all clients.
Heavily inspired by:
redis/jedis#4015
redis/redis-py#3415
Changes include:
Change to workflows to use the new infra
Deletion of old way to deploy redis, everything will use docker deployed-redis.
Thinning out and adding all redis.confs to be properly visible, and groupign them wherever needed.
Docker compose file.
Fixes to README explaining the new way to deploy.
Using and testing against latest Redis CE and enabling ourselves to start testing against Redis Enterprise.
Fixes to these tests in regards to new infra:
Now we can just use docker self-signed certificates and then create keystores based on that via java.