Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme doc on how to connect to Azure Managed Redis with Entra ID authentication #3166

Merged
merged 10 commits into from
Feb 16, 2025

Conversation

ggivo
Copy link
Contributor

@ggivo ggivo commented Feb 7, 2025

Readme doc on how to connect to Azure Managed Redis (AMR) and Azure Cache for Redis (ACR) with Entra ID authentication

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should elaborate more on the other types of CredentialProviders? And also expand on the idea of streaming credential providers?

@ggivo
Copy link
Contributor Author

ggivo commented Feb 9, 2025

Do you think we should elaborate more on the other types of CredentialProviders? And also expand on the idea of streaming credential providers?

@tishun
Updated the review with additional section for how to implement/use a Streaming Credentials. Could you take a look?

Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Co-authored-by: Tihomir Krasimirov Mateev <[email protected]>
@tishun
Copy link
Collaborator

tishun commented Feb 14, 2025

@ggivo I think you'd have to rebase and include my fix to the tests from the main branch

@ggivo ggivo merged commit 06496ed into redis:main Feb 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants