Skip to content

Missing index is not handled properly in "dropIndex" on recent Redis #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Missing index is not handled properly in "dropIndex" on recent Redis #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/repository/repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,11 @@ export class Repository<T extends Entity = Record<string, any>> {
/* NOTE: It would be better if this error handler was only around the call
to `.dropIndex`. Might muss up the code a bit though. Life is full of
tough choices. */
if (e instanceof Error && (e.message === "Unknown Index name" || e.message === "Unknown index name")) {
if (e instanceof Error && (
e.message === "Unknown Index name"
|| e.message === "Unknown index name"
|| e.message.includes("no such index")
)) {
// no-op: the thing we are dropping doesn't exist
} else {
throw e
Expand Down