-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Adding ssl_verify_flags_config argument for ssl connection configuration #3772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ssl_verify_flags_config argument for ssl connection configuration #3772
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for SSL verification flags configuration in Redis connections by introducing the ssl_verify_flags_config
parameter. This allows users to customize SSL certificate verification behavior for both synchronous and asynchronous Redis connections.
- Added
ssl_verify_flags_config
parameter to configure SSL verification flags - Implemented URL parsing support for the new SSL parameter
- Added comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
redis/connection.py | Added ssl_verify_flags_config parameter and URL parsing logic for sync connections |
redis/asyncio/connection.py | Added ssl_verify_flags_config parameter and URL parsing logic for async connections |
redis/client.py | Added ssl_verify_flags_config parameter to Redis client constructor |
redis/asyncio/client.py | Added ssl_verify_flags_config parameter to async Redis client constructor |
redis/cluster.py | Added ssl_verify_flags_config to cluster SSL parameters list |
redis/asyncio/cluster.py | Added ssl_verify_flags_config parameter to async cluster client |
tests/test_ssl.py | Added test for SSL flags configuration in sync connections |
tests/test_asyncio/test_ssl.py | Added test for SSL flags configuration in async connections |
tests/test_connection_pool.py | Added tests for URL parsing of SSL flags configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
9df116f
to
a2bfbff
Compare
a2bfbff
to
91bca08
Compare
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Fixes #3685