gha: add ECR as registry to push images to #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivotron
force-pushed
the
add-ecr-repo
branch
6 times, most recently
from
11d1c7a to
05234ae
Compare
|
These changes were tested from a DNM change in 11d1c7a (that was reverted). The resulting run of the workflow is in https://github.com/redpanda-data/kminion/actions/runs/13961649257, with an image successfully pushed to https://gallery.ecr.aws/l9j0i2e0/kminion (tag |
ivotron
commented
Mar 20, 2025
| @@ -47,6 +48,14 @@ jobs: | |||
| with: | |||
| username: ${{ env.DOCKERHUB_USER }} | |||
| password: ${{ env.DOCKERHUB_TOKEN }} | |||
| - uses: aws-actions/configure-aws-credentials@v4 | |||
| with: | |||
| aws-region: us-east-1 | |||
There was a problem hiding this comment.
this has to be us-east-1 as this is the only region that supports public ECR repos
Signed-off-by: Ivo Jimenez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an ECR registry as another publishing target for images. The AWS IAM role that is assumed as part of the execution of this workflow contains the right permissions to allow the login and push operation to work as it should.
part of https://redpandadata.atlassian.net/browse/DEVPROD-2735