Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk: add rpk generate license #24760

Merged
merged 1 commit into from
Jan 31, 2025
Merged

rpk: add rpk generate license #24760

merged 1 commit into from
Jan 31, 2025

Conversation

r-vasquez
Copy link
Contributor

This new command allows users to request a free trial license for 30 days using rpk

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@r-vasquez r-vasquez requested a review from sago2k8 January 9, 2025 23:26
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jan 10, 2025 •
edited
Loading

Retry command for Build#60551

please wait until all jobs are finished before running the slash command


/ci-repeat 1
tests/rptest/tests/cloud_storage_scrubber_test.py::CloudStorageScrubberTest.test_scrubber@{"cloud_storage_type":2}
tests/rptest/tests/archival_test.py::ArchivalTest.test_all_partitions_leadership_transfer@{"cloud_storage_type":1}

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jan 10, 2025 •
edited
Loading

CI test results

test results on build#60551
test_id test_kind job_url test_status passed
rm_stm_tests_rpunit.rm_stm_tests_rpunit unit https://buildkite.com/redpanda/redpanda/builds/60551#01944d66-9cd0-4a0a-a551-41431e14675c FLAKY 1/2
rm_stm_tests_rpunit.rm_stm_tests_rpunit unit https://buildkite.com/redpanda/redpanda/builds/60551#01944d66-9cd2-4644-a866-c85f59867b7c FLAKY 1/2
rptest.tests.archival_test.ArchivalTest.test_all_partitions_leadership_transfer.cloud_storage_type=CloudStorageType.S3 ducktape https://buildkite.com/redpanda/redpanda/builds/60551#01944dc3-824c-43f1-9511-b14b18f9703b FAIL 0/1
rptest.tests.cloud_storage_scrubber_test.CloudStorageScrubberTest.test_scrubber.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/60551#01944dc1-e34e-4824-ba83-f8db8c769b2b FAIL 0/1
test results on build#60676
test_id test_kind job_url test_status passed
rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_mount_inexistent ducktape https://buildkite.com/redpanda/redpanda/builds/60676#019462d7-88d9-483d-b99a-8c85f12e2041 FLAKY 5/6
rptest.tests.partition_reassignments_test.PartitionReassignmentsTest.test_reassignments_kafka_cli ducktape https://buildkite.com/redpanda/redpanda/builds/60676#019462c4-cad6-4500-a61e-f9e1e1c333d1 FLAKY 4/6
test results on build#60688
test_id test_kind job_url test_status passed
gtest_raft_rpunit.gtest_raft_rpunit unit https://buildkite.com/redpanda/redpanda/builds/60688#01946397-56cd-47af-bbce-5b01d07a29be FLAKY 1/2
rptest.tests.partition_reassignments_test.PartitionReassignmentsTest.test_reassignments_kafka_cli ducktape https://buildkite.com/redpanda/redpanda/builds/60688#019463f2-12cb-4c50-bdce-95b21daaa16d FLAKY 3/6
test results on build#60718
test_id test_kind job_url test_status passed
rptest.tests.compaction_recovery_test.CompactionRecoveryUpgradeTest.test_index_recovery_after_upgrade ducktape https://buildkite.com/redpanda/redpanda/builds/60718#01946625-d9d5-4423-ba39-393309e2d9ac FLAKY 5/6
rptest.tests.consumer_group_balancing_test.ConsumerGroupBalancingTest.test_coordinator_nodes_balance ducktape https://buildkite.com/redpanda/redpanda/builds/60718#01946629-deef-4424-9cac-27307f592235 FLAKY 5/6
test results on build#61078
test_id test_kind job_url test_status passed
rptest.tests.compaction_recovery_test.CompactionRecoveryUpgradeTest.test_index_recovery_after_upgrade ducktape https://buildkite.com/redpanda/redpanda/builds/61078#019490da-a3c8-42fc-9085-094c0225e936 FLAKY 1/2
rptest.tests.partition_balancer_test.PartitionBalancerTest.test_unavailable_nodes ducktape https://buildkite.com/redpanda/redpanda/builds/61078#019490da-a3c8-42fc-9085-094c0225e936 FLAKY 1/2
test results on build#61185
test_id test_kind job_url test_status passed
gtest_raft_rpunit.gtest_raft_rpunit unit https://buildkite.com/redpanda/redpanda/builds/61185#01949a5e-c63a-483f-a6c6-cea01d4bd112 FLAKY 1/2
test results on build#61336
test_id test_kind job_url test_status passed
rptest.tests.compaction_recovery_test.CompactionRecoveryTest.test_index_recovery ducktape https://buildkite.com/redpanda/redpanda/builds/61336#0194b15c-1234-4c6e-ad62-8b012da644bd FLAKY 1/6
rptest.tests.consumer_offsets_consistency_test.ConsumerOffsetsConsistencyTest.test_flipping_leadership ducktape https://buildkite.com/redpanda/redpanda/builds/61336#0194b13f-686e-4303-b25f-01430098c2f5 FLAKY 1/2
rptest.tests.datalake.compaction_test.CompactionGapsTest.test_translation_no_gaps.cloud_storage_type=CloudStorageType.S3 ducktape https://buildkite.com/redpanda/redpanda/builds/61336#0194b15c-1231-4afc-b822-e05f75044361 FLAKY 1/4
test results on build#61417
test_id test_kind job_url test_status passed
rptest.tests.compaction_recovery_test.CompactionRecoveryTest.test_index_recovery ducktape https://buildkite.com/redpanda/redpanda/builds/61417#0194b9e9-521f-468a-827f-7912cd5480da FLAKY 1/3
rptest.tests.compaction_recovery_test.CompactionRecoveryTest.test_index_recovery ducktape https://buildkite.com/redpanda/redpanda/builds/61417#0194b9ee-a511-4a93-9d76-d5df48b74bfb FLAKY 1/2
rptest.tests.datalake.compaction_test.CompactionGapsTest.test_translation_no_gaps.cloud_storage_type=CloudStorageType.S3 ducktape https://buildkite.com/redpanda/redpanda/builds/61417#0194b9ee-a50e-4ce0-85bb-ecdc06cf6f52 FLAKY 1/3
rptest.tests.e2e_shadow_indexing_test.ShadowIndexingWhileBusyTest.test_create_or_delete_topics_while_busy.short_retention=True.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/61417#0194b9ee-a50e-4ce0-85bb-ecdc06cf6f52 FLAKY 1/3

@r-vasquez r-vasquez force-pushed the rpk-generate-license branch from 33bb805 to 1be0cd9 Compare January 13, 2025 19:46
@r-vasquez r-vasquez force-pushed the rpk-generate-license branch 4 times, most recently from 391846f to 07069df Compare January 14, 2025 17:09
Deflaimun
Deflaimun previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@Deflaimun Deflaimun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from docs

@r-vasquez r-vasquez force-pushed the rpk-generate-license branch from 07069df to c851aa9 Compare January 23, 2025 00:03
@r-vasquez r-vasquez requested a review from a team as a code owner January 23, 2025 00:03
@r-vasquez
Copy link
Contributor Author

Updated the text with @mo-redpanda and @micheleRP suggestions.

I'll add the --apply flag in a follow-up commit.

@r-vasquez r-vasquez force-pushed the rpk-generate-license branch 2 times, most recently from 3162d7b to b4b01aa Compare January 29, 2025 07:31
@r-vasquez r-vasquez requested a review from micheleRP January 29, 2025 07:32
micheleRP
micheleRP reviewed Jan 30, 2025
View reviewed changes
src/go/rpk/pkg/cli/generate/license.go Outdated
cmd.Flags().BoolVar(&apply, "apply", false, "Apply the generated license to your Redpanda cluster")
// License request info.
cmd.Flags().StringVar(&lr.name, "name", "", "First name for trial license registration")
cmd.Flags().StringVar(&lr.lastname, "last-name", "", "Last name for register trial license registration")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cmd.Flags().StringVar(&lr.lastname, "last-name", "", "Last name for register trial license registration")
cmd.Flags().StringVar(&lr.lastname, "last-name", "", "Last name for trial license registration")

micheleRP
micheleRP reviewed Jan 30, 2025
View reviewed changes
src/go/rpk/pkg/cli/generate/license.go Outdated
This command generates a license for a 30-day trial of Redpanda Enterprise
Edition.

If you require a permanent license, contact us: https://www.redpanda.com/contact
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you require a permanent license, contact us: https://www.redpanda.com/contact
To get a permanent license, contact us: https://www.redpanda.com/contact

micheleRP
micheleRP reviewed Jan 30, 2025
View reviewed changes
src/go/rpk/pkg/cli/generate/license.go Outdated
The license will be saved in your working directory or the specified path, based
on the --path flag.

If you want to apply the license to your cluster, use the --apply flag.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you want to apply the license to your cluster, use the --apply flag.
To apply the license to your cluster, use the --apply flag.

micheleRP
micheleRP reviewed Jan 30, 2025
View reviewed changes
src/go/rpk/pkg/cli/generate/license.go Outdated

If you require a permanent license, contact us: https://www.redpanda.com/contact

The license will be saved in your working directory or the specified path, based
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The license will be saved in your working directory or the specified path, based
The license is saved in your working directory or the specified path, based

micheleRP
micheleRP previously approved these changes Jan 30, 2025
View reviewed changes
Copy link

@micheleRP micheleRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rogger! I added a copy other suggestions, just nice to have.

@r-vasquez
rpk: add rpk generate license
e649621 
It uses the public API to request a free trial
license for 30 days.
@r-vasquez r-vasquez force-pushed the rpk-generate-license branch from b4b01aa to e649621 Compare January 30, 2025 23:56
micheleRP
micheleRP approved these changes Jan 31, 2025
View reviewed changes
Copy link

@micheleRP micheleRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rogger!

@r-vasquez r-vasquez merged commit 5f7b475 into redpanda-data:dev Jan 31, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mo-redpanda mo-redpanda mo-redpanda approved these changes

@micheleRP micheleRP micheleRP approved these changes

@Deflaimun Deflaimun Deflaimun left review comments

@sago2k8 sago2k8 Awaiting requested review from sago2k8

@kbatuigas kbatuigas Awaiting requested review from kbatuigas kbatuigas is a code owner

Assignees
No one assigned
Labels
area/build area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@r-vasquez @vbotbuildovich @Deflaimun @kbatuigas @mo-redpanda @micheleRP