kafka/server: add metrics and config for consumer lag reporting #24977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IoannisRP
changed the title
CI test resultstest results on build#61359
test results on build#61509
|
BenPope
reviewed
Feb 3, 2025
Comment on lines
+170
to
+174
| "Sum of consumer group lag for all partitions in a group"), | ||
| labels), | ||
| sm::make_gauge( | ||
| "lag_max", | ||
| [this] { return _lag_metrics.max; }, | ||
| sm::description( | ||
| "Maximum consumer group lag across all partitions in a group"), |
There was a problem hiding this comment.
Maybe one for docs, but topic-partitions might be more easily understood.
There was a problem hiding this comment.
Like this?
Suggested change
| "Sum of consumer group lag for all partitions in a group"), | |
| labels), | |
| sm::make_gauge( | |
| "lag_max", | |
| [this] { return _lag_metrics.max; }, | |
| sm::description( | |
| "Maximum consumer group lag across all partitions in a group"), | |
| "Sum of consumer group lag for all topic-partitions"), | |
| labels), | |
| sm::make_gauge( | |
| "lag_max", | |
| [this] { return _lag_metrics.max; }, | |
| sm::description( | |
| "Maximum consumer group lag across topic-partitions"), |
BenPope
reviewed
Feb 3, 2025
| @@ -196,6 +196,7 @@ struct configuration final : public config_store { | |||
| property<bool> disable_metrics; | |||
| property<bool> disable_public_metrics; | |||
| property<bool> aggregate_metrics; | |||
| property<bool> enable_consumer_group_lag_metrics; | |||
There was a problem hiding this comment.
I wonder if we should have more than a bool here.
I see a use for:
- partition-level metrics (what we have with
redpanda_kafka_consumer_group_committed_offset) - consumer_lag (this)
- both
enable_group_metrics is hard-coded as on (off in some tests), so it could be wrapped up.
Perhaps enable_group_metrics with options partition, group. Not sure how to spell the option both, if, perhaps, we wanted to add topic one day. Maybe the accepted values could be something like partition|lag.
There was a problem hiding this comment.
This sounds like something maybe we can tackle in future metrics rework?
IoannisRP
force-pushed
the
CORE-8914/consumer_lag_config
branch
from
76291af to
53aa756
Compare
config: Add consumer lag metric config Note that this commit contains only the metric infrastructure, i.e. the probe and the mechanism to dynamically enable/disable these metrics. A subsequent commit will implement the logic to populate the consumer lag metrics data.
IoannisRP
force-pushed
the
CORE-8914/consumer_lag_config
branch
from
53aa756 to
b880e01
Compare
|
Changes in force-push:
Changes in force-push:
|
asimms41
reviewed
Feb 7, 2025
| , enable_consumer_group_lag_metrics( | ||
| *this, | ||
| "enable_consumer_group_lag_metrics", | ||
| "Enable registering metrics for consumer group lag exposed on " |
There was a problem hiding this comment.
Suggested change
| "Enable registering metrics for consumer group lag exposed on " | |
| "Enable metrics for consumer group lag exposed on " |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: https://redpandadata.atlassian.net/browse/CORE-8914
Introduce "enable_consumer_group_lag_metrics" which controls whether the consumer lag metrics are active. This can be changed without needing a restart.
Introduce the metrics scaffolding needed to have metrics that can be enabled/disabled at runtime.
redpanda_kafka_consumer_group_lag_maxgroup,shardredpanda_kafka_consumer_group_lag_sumgroup,shardBackports Required
Release Notes