-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: fix numactl #25041
base: dev
Are you sure you want to change the base?
bazel: fix numactl #25041
Conversation
This breaks in bazel 8, so fix it now
required to work with Bazel 8
i'm not saying we should do this, but from what I can tell seastar's libnuma dependency is a single call to looking at this: https://github.com/lrita/numa/blob/29f88905963797c57362861a2dd8adb14a6f152a/numa_linux.go#L161 i do wonder if freeing ourselves from the libnuma dependency would be as simple as writing our own version of this
|
@@ -6,7 +6,8 @@ edition = "2021" | |||
publish = false | |||
|
|||
[lib] | |||
path = "/dev/null" | |||
# Use a fake path here, but rules_rust requires something. | |||
path = "./dev/null" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. i had gone with fake.rs
ooh maybe I will send a patch to seastar and see what drama unfolds... |
Incorporate libnuma into the Bazel build. We force dynamic linking because it's LGPL. The dynamic linking forcing is really annoying, but honestly less annoying than the new way of doing things with
cc_shared_library
. However I ran into issues using thecc_shared_library
approach, so I just fallback to using the "old school" stable ways of making shared libraries.Backports Required
Release Notes