Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx/rm_stm: remove support for stale snapshot versions #25055

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

bharathv
Copy link
Contributor

@bharathv bharathv commented Feb 6, 2025

Remove dead code. These snapshot versions (and related code) are no longer relevant going forward.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Feb 7, 2025

Retry command for Build#61698

please wait until all jobs are finished before running the slash command



/ci-repeat 1
tests/rptest/tests/alter_topic_configuration_test.py::AlterConfigMixedNodeTest.test_alter_config_shadow_indexing_mixed_node@{"incremental_update":true}
tests/rptest/tests/shard_placement_test.py::ShardPlacementTest.test_upgrade
tests/rptest/tests/alter_topic_configuration_test.py::AlterConfigMixedNodeTest.test_alter_config_shadow_indexing_mixed_node@{"incremental_update":false}

@vbotbuildovich
Copy link
Collaborator

CI test results

test results on build#61698
test_id test_kind job_url test_status passed
gtest_raft_rpunit.gtest_raft_rpunit unit https://buildkite.com/redpanda/redpanda/builds/61698#0194dd39-9e21-4e24-a1f3-0c342930ed31 FLAKY 1/2
rptest.tests.alter_topic_configuration_test.AlterConfigMixedNodeTest.test_alter_config_shadow_indexing_mixed_node.incremental_update=False ducktape https://buildkite.com/redpanda/redpanda/builds/61698#0194dd98-d5c3-4d79-9d63-b20490a1b9c2 FAIL 0/20
rptest.tests.alter_topic_configuration_test.AlterConfigMixedNodeTest.test_alter_config_shadow_indexing_mixed_node.incremental_update=False ducktape https://buildkite.com/redpanda/redpanda/builds/61698#0194dd9e-f587-41cc-9bc6-169fa60d758a FAIL 0/20
rptest.tests.alter_topic_configuration_test.AlterConfigMixedNodeTest.test_alter_config_shadow_indexing_mixed_node.incremental_update=True ducktape https://buildkite.com/redpanda/redpanda/builds/61698#0194dd98-d5c4-4e77-b15e-d1b9dbc10c22 FAIL 0/20
rptest.tests.alter_topic_configuration_test.AlterConfigMixedNodeTest.test_alter_config_shadow_indexing_mixed_node.incremental_update=True ducktape https://buildkite.com/redpanda/redpanda/builds/61698#0194dd9e-f588-4f31-90ca-9e97786f0f2c FAIL 0/20
rptest.tests.compaction_recovery_test.CompactionRecoveryUpgradeTest.test_index_recovery_after_upgrade ducktape https://buildkite.com/redpanda/redpanda/builds/61698#0194dd9e-f588-4f31-90ca-9e97786f0f2c FLAKY 1/2
rptest.tests.datalake.compaction_test.CompactionGapsTest.test_translation_no_gaps.cloud_storage_type=CloudStorageType.S3.catalog_type=CatalogType.REST_HADOOP ducktape https://buildkite.com/redpanda/redpanda/builds/61698#0194dd98-d5c4-4e77-b15e-d1b9dbc10c22 FLAKY 1/4
rptest.tests.datalake.compaction_test.CompactionGapsTest.test_translation_no_gaps.cloud_storage_type=CloudStorageType.S3.catalog_type=CatalogType.REST_JDBC ducktape https://buildkite.com/redpanda/redpanda/builds/61698#0194dd98-d5c2-416d-9612-61edc58a19e4 FLAKY 1/2
rptest.tests.datalake.datalake_e2e_test.DatalakeE2ETests.test_topic_lifecycle.cloud_storage_type=CloudStorageType.S3.catalog_type=CatalogType.REST_HADOOP ducktape https://buildkite.com/redpanda/redpanda/builds/61698#0194dd9e-f587-41cc-9bc6-169fa60d758a FLAKY 1/2
rptest.tests.e2e_shadow_indexing_test.EndToEndHydrationTimeoutTest.test_hydration_completes_on_timeout ducktape https://buildkite.com/redpanda/redpanda/builds/61698#0194dd9e-f586-4bb2-8801-9f63bab02e8b FLAKY 1/2
rptest.tests.shard_placement_test.ShardPlacementTest.test_upgrade ducktape https://buildkite.com/redpanda/redpanda/builds/61698#0194dd98-d5c2-4324-804c-b5cff981c4d2 FAIL 0/20
rptest.tests.shard_placement_test.ShardPlacementTest.test_upgrade ducktape https://buildkite.com/redpanda/redpanda/builds/61698#0194dd9e-f587-41cc-9bc6-169fa60d758a FAIL 0/20

Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove dead code. These snapshot versions (and related code) are no longer relevant going forward.

it might be useful to understand how we know we wouldn't encounter them somewhere on some cluster, or how we know if they were to exist that they wouldn't be an issue after this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants