-
Notifications
You must be signed in to change notification settings - Fork 12
Update quickstart.adoc #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for redpanda-connect ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughA single documentation edit in modules/ai-agents/pages/mcp-server/quickstart.adoc updates the Prerequisites list: two bullets about Redpanda Connect version and upgrade guidance are merged into one bullet, stating "Redpanda Connect 4.56.0 or later" and retaining the upgrade reference. No code or API changes; no public/exported entities affected. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| - At least version 4.56.0 of Redpanda Connect | ||
| + | ||
| If you need to upgrade, see xref:get-started:upgrade/rpk-upgrade.adoc[]. | ||
| - Redpanda Connect 4.56.0 or later. If you need to upgrade, see xref:get-started:upgrade/rpk-upgrade.adoc[]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think rpk-upgrade.adoc should include a section to check your RPCN version, similar to https://docs.redpanda.com/current/get-started/rpk-install/#check-rpk-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevermind, it does!
| - At least version 4.56.0 of Redpanda Connect | ||
| + | ||
| If you need to upgrade, see xref:get-started:upgrade/rpk-upgrade.adoc[]. | ||
| - Redpanda Connect 4.56.0 or later. If you need to upgrade, see xref:get-started:upgrade/rpk-upgrade.adoc[]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but this could just be a link, similar to the one above, like:
- xref:get-started:upgrade/rpk-upgrade.adoc[Redpanda Connect 4.56.0 or later]
|
closing as the conversation moved to #314 |
Description
Resolves https://github.com/redpanda-data/documentation-private/issues/
Review deadline:
Page previews
Checks