-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(web): remove api key input for google map photorealistics [VIZ-1411] #1524
Conversation
WalkthroughThis pull request removes the handling of the Google Maps API key from the ThreeDTiles component. The changes delete the state management, input field rendering, and related logic (including submit and change handlers) for the API key. Additionally, the corresponding translation entries in both English and Japanese locales have been removed. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ThreeDTiles
participant Service
User->>ThreeDTiles: Select "Google Photorealistic 3D Tiles"
Note right of ThreeDTiles: Skips API key input rendering
User->>ThreeDTiles: Submit configuration
ThreeDTiles->>Service: Send data source config (without API key)
Service-->>ThreeDTiles: Confirm configuration
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (6)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
web/package.json (1)
132-132
: Dependency Version Update VerificationThe dependency
@reearth/core
has been updated to"0.0.7-alpha.34"
. Please ensure that all breaking changes or updates introduced in this new alpha version have been verified through integration tests.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
web/yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
,!**/*.lock
📒 Files selected for processing (1)
web/package.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: ci-web / ci
- GitHub Check: ci-server / ci-server-test
- GitHub Check: ci-server / ci-server-lint
- GitHub Check: Redirect rules - reearth-web
- GitHub Check: Header rules - reearth-web
- GitHub Check: Pages changed - reearth-web
…re/google-photorealistic
Overview
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo
Summary by CodeRabbit
Refactor
Documentation
Chores
@reearth/core
dependency to a newer alpha version.