Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): remove api key input for google map photorealistics [VIZ-1411] #1524

Merged
merged 4 commits into from
Mar 27, 2025

Conversation

mkumbobeaty
Copy link
Contributor

@mkumbobeaty mkumbobeaty commented Mar 25, 2025

Overview

  • The Pr supports adding Google photorealistic 3D tiles without making use of Google map api key

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Summary by CodeRabbit

  • Refactor

    • Removed the option to enter a Google Maps API key from the map configuration, streamlining the available 3D tiles setup.
  • Documentation

    • Removed obsolete translation entries related to the Google Maps API key in both English and Japanese.
  • Chores

    • Updated the version of the @reearth/core dependency to a newer alpha version.

Copy link

coderabbitai bot commented Mar 25, 2025

Walkthrough

This pull request removes the handling of the Google Maps API key from the ThreeDTiles component. The changes delete the state management, input field rendering, and related logic (including submit and change handlers) for the API key. Additionally, the corresponding translation entries in both English and Japanese locales have been removed.

Changes

File(s) Change Summary
web/src/beta/features/.../ThreeDTiles/index.tsx Removed googleMapsApiKey state, its setter, the renderGooglePhotorealisticInput function, and updates to handleDataSourceTypeChange and handleSubmit to omit API key processing.
web/src/services/i18n/translations/{en,ja}.yml Removed translation entries related to “Google Maps API Key”, “You can apply a key”, and “here” in both English and Japanese localization files.
web/package.json Updated @reearth/core dependency version from 0.0.7-alpha.33 to 0.0.7-alpha.34.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant ThreeDTiles
  participant Service

  User->>ThreeDTiles: Select "Google Photorealistic 3D Tiles"
  Note right of ThreeDTiles: Skips API key input rendering
  User->>ThreeDTiles: Submit configuration
  ThreeDTiles->>Service: Send data source config (without API key)
  Service-->>ThreeDTiles: Confirm configuration
Loading

Possibly related PRs

Poem

I hop in code with joyful grace,
No API key to clutter this space.
The ThreeDTiles dance now light and free,
As bugs retreat and errors cease to be.
With each small tweak, my heart does sing,
For a cleaner app, I love every spring!
🐰 Hop on to a brighter coding day!


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 79c1fd9 and 94d6e47.

📒 Files selected for processing (2)
  • web/src/services/i18n/translations/en.yml (0 hunks)
  • web/src/services/i18n/translations/ja.yml (0 hunks)
💤 Files with no reviewable changes (2)
  • web/src/services/i18n/translations/en.yml
  • web/src/services/i18n/translations/ja.yml
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: Redirect rules - reearth-web
  • GitHub Check: Header rules - reearth-web
  • GitHub Check: Pages changed - reearth-web
  • GitHub Check: ci-server / ci-server-lint
  • GitHub Check: ci-server / ci-server-test
  • GitHub Check: ci-web / ci

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mkumbobeaty mkumbobeaty marked this pull request as ready for review March 25, 2025 07:14
@github-actions github-actions bot added the web label Mar 25, 2025
@mkumbobeaty mkumbobeaty requested a review from airslice as a code owner March 25, 2025 07:14
@github-actions github-actions bot requested a review from m-abe-dev March 25, 2025 07:14
Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 94d6e47
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/67e4e935e5f6ab0009cc38bc
😎 Deploy Preview https://deploy-preview-1524--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mkumbobeaty mkumbobeaty changed the title refactor(web): google map photorealistics refactor(web): google map photorealistics [VIZ-1411] Mar 25, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
web/package.json (1)

132-132: Dependency Version Update Verification

The dependency @reearth/core has been updated to "0.0.7-alpha.34". Please ensure that all breaking changes or updates introduced in this new alpha version have been verified through integration tests.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5bae09d and 79c1fd9.

⛔ Files ignored due to path filters (1)
  • web/yarn.lock is excluded by !**/yarn.lock, !**/*.lock, !**/*.lock
📒 Files selected for processing (1)
  • web/package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: ci-web / ci
  • GitHub Check: ci-server / ci-server-test
  • GitHub Check: ci-server / ci-server-lint
  • GitHub Check: Redirect rules - reearth-web
  • GitHub Check: Header rules - reearth-web
  • GitHub Check: Pages changed - reearth-web

@airslice airslice changed the title refactor(web): google map photorealistics [VIZ-1411] refactor(web): remove api key input for google map photorealistics [VIZ-1411] Mar 26, 2025
@mkumbobeaty mkumbobeaty merged commit dca0d73 into main Mar 27, 2025
19 checks passed
@mkumbobeaty mkumbobeaty deleted the chore/google-photorealistic branch March 27, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants