chore(server, web): remove ArcGIS terrain [VIZ-1424]

[mkumbobeaty]

Overview

Removed ArcGIS Terrain from Scene/Terrain Option because it requires license.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Summary by CodeRabbit

These changes update terrain selection handling to provide a more streamlined user experience. Users will now see only two terrain options, ensuring clarity in selection.

• Refactor
  • Removed the ArcGIS Terrain option, leaving only Cesium World Terrain and Cesium Ion as selectable terrain types.

[coderabbitai]

Walkthrough

The pull request removes the "arcgis" terrain option from the available terrain types. This update is applied across the manifest files for both default and Japanese configurations as well as in the TypeScript type definitions. The change leaves only "cesium" and "cesiumion" as valid choices for terrain selection while preserving the overall schema structure and default value.

Changes

File(s)	Change Summary
server/pkg/builtin/manifest.yml server/pkg/builtin/manifest_ja.yml	Removed the "arcgis" terrain option from the terrain type choices in the manifest schemas.
web/src/beta/types/sceneProperty.ts	Updated type definitions by excluding "arcgis" from the terrainType values in both TerrainProperty and LegacySceneProperty.

Possibly related PRs

• fix(web): terrain not applied properly on editor #1260: Addresses terrain handling by altering schema options to remove "arcgis".
• refactor(web, server): Refacting depth test against terrain to globe  #1161: Removes "arcgis" from the terrainType property in type definitions.
• chore(server, web): filter out classic asset from visualizer #1095: Implements removal of "arcgis" from terrainType in the TypeScript type declarations.

Suggested reviewers

• airslice
• pyshx

Poem

Hey there, I'm a rabbit, hopping in delight,
"Arcgis" is gone from our code, out of sight!
Only "cesium" and "cesiumion" now play their part,
Skipping the extra choice, a light for the heart.
Hop on over with a carrot, coding feels just right!
🥕🐇

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 46a0837 and 4c8139a.

📒 Files selected for processing (3)

• server/pkg/builtin/manifest.yml (0 hunks)
• server/pkg/builtin/manifest_ja.yml (0 hunks)
• web/src/beta/types/sceneProperty.ts (2 hunks)

💤 Files with no reviewable changes (2)

• server/pkg/builtin/manifest_ja.yml
• server/pkg/builtin/manifest.yml

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Redirect rules - reearth-web
• GitHub Check: Header rules - reearth-web
• GitHub Check: Pages changed - reearth-web
• GitHub Check: ci-server / ci-server-test

🔇 Additional comments (2)

web/src/beta/types/sceneProperty.ts (2)

7-7: The removal of "arcgis" terrain type aligns with the PR objective.

The change correctly removes the "arcgis" option from the terrain type definition in the TerrainProperty interface while preserving the "cesium" and "cesiumion" options, as intended by the PR to remove ArcGIS terrain due to licensing requirements.

---

113-113:

✅ Verification successful

Consistent removal of "arcgis" in LegacySceneProperty.

The same change has been correctly applied to the terrainType in the LegacySceneProperty type, maintaining consistency across the codebase. This ensures that ArcGIS terrain is completely removed from both the new and legacy type definitions.

---

🏁 Script executed:

#!/bin/bash
# Verify that no references to "arcgis" terrain type remain in the codebase
# that might rely on this removed option

echo "Searching for any remaining references to arcgis terrain type..."
rg -i "terrainType.*arcgis" --type ts --type js

Length of output: 188

---

Verified: Consistent Removal of "arcgis" from Terrain Types

The automated search for terrainType.*arcgis produced no results in the codebase. This confirms that the removal of the "arcgis" option has been applied consistently both in the new definition (as seen in web/src/beta/types/sceneProperty.ts at line 113) and in the LegacySceneProperty type.

• The new type now only allows "cesium" and "cesiumion", which is in line with the intended change.
• No stray references to "arcgis" were found in any TypeScript or JavaScript files.

Based on the verification, the code change appears correctly implemented. However, please perform a manual check if you suspect any indirect dependencies might still reference "arcgis".

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for reearth-web ready!

Name	Link
🔨 Latest commit	4c8139a
🔍 Latest deploy log	https://app.netlify.com/sites/reearth-web/deploys/67e268bb8a439c00085ed596
😎 Deploy Preview	https://deploy-preview-1525--reearth-web.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[soneda-yuya]

LGTM!