Skip to content

Fix tests on macOS for -f make,ninja #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix tests on macOS for -f make,ninja #44

wants to merge 4 commits into from

Conversation

@shawwn
Copy link
Contributor

@shawwn shawwn commented May 4, 2019

I noticed pipenv run -v test -f make,ninja was failing on macOS:

$ pipenv run -v test -f make,ninja

... snip ...

Failed the following 4 tests:
	(test/mac/gyptest-archs.py) make
	(test/mac/gyptest-deployment-target.py) ninja
	(test/mac/gyptest-type-envvars.py) make
	(test/mac/gyptest-type-envvars.py) ninja

Ran 714 tests in 513.727s, 4 failed.

This is my attempt at fixing them.

shawwn added 4 commits May 3, 2019 19:08
@shawwn
test: Remove old xcodeversion detection
644bc80 
This fixes test/mac/gyptest-type-envvars.py on macOS
@shawwn
test,mac: Remove i386 target
e0da07a 
This fixestest/mac/gyptest-archs.py for --format make
@shawwn
test,mac: Uprade deployment target, reenable make
ee99e55 
Fix fixestest/mac/gyptest-deployment-target.py on macOS by building
against macOS 10.9 and 10.14 using clang with libc++
@shawwn
testlib: Make CheckFileType_macOS more robust
64c775a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shawwn