Test for various cli parameter invocations #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrsamsung
force-pushed
the
mbr/issue-128-unit-tests
branch
3 times, most recently
from
7d17837 to
ca4eea1
Compare
Pull Request Test Coverage Report for Build 13197802809Details
💛 - Coveralls |
mbrsamsung
force-pushed
the
mbr/issue-128-unit-tests
branch
3 times, most recently
from
57a39f6 to
fb7fc54
Compare
mbrsamsung
changed the title
mbrsamsung
force-pushed
the
mbr/issue-128-unit-tests
branch
from
fb7fc54 to
2e54b0c
Compare
mbrsamsung
force-pushed
the
mbr/issue-128-unit-tests
branch
15 times, most recently
from
76710d6 to
6e57aef
Compare
mbrsamsung
force-pushed
the
mbr/issue-128-unit-tests
branch
from
6e57aef to
24b3b12
Compare
safl
force-pushed
the
main
branch
8 times, most recently
from
d0c8bd7 to
2a4d5f0
Compare
mbrsamsung
force-pushed
the
mbr/issue-128-unit-tests
branch
2 times, most recently
from
ef74a57 to
d6d295c
Compare
safl
reviewed
Feb 3, 2025
mbrsamsung
force-pushed
the
mbr/issue-128-unit-tests
branch
2 times, most recently
from
c151e9f to
01f9b4b
Compare
safl
requested changes
Feb 7, 2025
| @@ -137,6 +138,8 @@ jobs: | |||
| cijoe --example ${{ matrix.usage_example }} | |||
|
|
|||
| - name: Run it! | |||
| env: | |||
| GHA_RUNNER_TOKEN: "BFGC6XRGGM7PUVLC5NYXARLHQ6FI6" | |||
There was a problem hiding this comment.
Why is this token added here?
There was a problem hiding this comment.
There where no other clear way, workflows that runs in a pull request and which are not initiated from a user of the project will not have the secrets included in the run. This will leave the build always failed in that use case.
There was a problem hiding this comment.
Ah! We are in the other PR. This was meant for GHA example. I guess the splitting up of the commits into PR's did result in this being included erroneously
| @@ -129,6 +129,7 @@ jobs: | |||
| - name: Build and install cijoe from source | |||
| run: | | |||
| pipx uninstall cijoe | |||
| pipx install build | |||
There was a problem hiding this comment.
This should not be needed. make deps on the next line does pipx-install?
Signed-off-by: Morten B. Rasmussen <[email protected]>
mbrsamsung
force-pushed
the
mbr/issue-128-unit-tests
branch
from
01f9b4b to
1bbe034
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.