Restore async test #270
Merged
Restore async test #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've made sure the async session is available during the test, which fixes Rails 8 However... the test is a little flakey on Rails >= 7.1 && < 8.0.2, due to a thread-safe bug in Rails. I've skipped the flakey part of the test in those versions
Owner
|
Thank you for the contribution @jdelStrother |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if available)
Followup to #248
Description of changes
I've made sure the async session is available during the async test, which fixes the test in Rails 8
However... the test is a little flakey on Rails >= 7.1 && < 8.0.2, due to a thread-safety bug in Rails. I've skipped the flakey part of the test in those versions
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.