Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sequencer #52

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update sequencer #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3223795
Replaced 'blockifier' with 'sequencer'
Eagle941 Oct 13, 2024
f337879
Improved readme
Eagle941 Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[env]
# These environment variables are needed because dependency `sequencer` requires llvm-18 installed.
LLVM_SYS_181_PREFIX = "/usr/lib/llvm-18/"
MLIR_SYS_180_PREFIX = "/usr/lib/llvm-18/"
TABLEGEN_180_PREFIX = "/usr/lib/llvm-18/"
Comment on lines +3 to +5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have concerns about just requiring the user to have this built and installed. You could consider a nix-based approach like we use in llvm-to-cairo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script dependencies.sh performs the installation of llvm-18 for users that don't have it installed

9 changes: 8 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@ name: Push Checks
on: push

env:
RUST_VERSION: 1.78.0 # If this is updated, update `Cargo.toml`.
RUST_VERSION: 1.81.0 # If this is updated, update `Cargo.toml`.
CARGO_TERM_COLOR: always
RUSTDOCFLAGS: "-D warnings" # Fail on `cargo doc` warnings.

jobs:
build:
name: Test
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest]
runs-on: ${{ matrix.os }}
Expand All @@ -26,6 +27,8 @@ jobs:
~/.cargo/registry/cache/
~/.cargo/git/db/
target/
- name: Install LLVM
run: bash dependencies.sh
- name: Build
run: cargo build --locked
- name: Run tests
Expand All @@ -47,6 +50,8 @@ jobs:
~/.cargo/registry/cache/
~/.cargo/git/db/
target/
- name: Install LLVM
run: bash dependencies.sh
- name: Cargo clippy
run: cargo clippy --locked --all-targets --all-features -- -D warnings

Expand Down Expand Up @@ -92,5 +97,7 @@ jobs:
~/.cargo/registry/cache/
~/.cargo/git/db/
target/
- name: Install LLVM
run: bash dependencies.sh
- name: Cargo doc
run: cargo doc --no-deps --document-private-items --locked
Loading
Loading