Raise error for nonexistent source tag [CLOUDDST-24434] (#286)

Source tag specified for removing tags should exist.

src/pubtools/_quay/tag_docker.py

@@ -322,6 +322,10 @@ def tag_remove_calculate_archs(
         if push_item.metadata["tag_source"]:
             source_image = "{0}:{1}".format(full_repo, push_item.metadata["tag_source"])
             source_details = self.get_image_details(source_image, executor)
+            if not source_details:
+                raise BadPushItem(
+                    "Source tag {0} doesn't exist".format(push_item.metadata["tag_source"])
+                )
         else:
             source_details = None
 

tests/test_tag_docker.py

@@ -817,6 +817,34 @@ def test_tag_remove_calculate_archs_no_src(
     assert ret == "something-other"
 
 
+@mock.patch("pubtools._quay.tag_docker.LocalExecutor")
+@mock.patch("pubtools._quay.tag_docker.TagDocker.get_image_details")
+def test_tag_remove_calculate_archs_nonexistent_src(
+    mock_get_image_details,
+    mock_local_executor,
+    target_settings,
+    tag_docker_push_item_remove_src,
+):
+    hub = mock.MagicMock()
+
+    mock_get_image_details.return_value = None
+    tag_docker_instance = tag_docker.TagDocker(
+        [tag_docker_push_item_remove_src],
+        hub,
+        "1",
+        "some-target",
+        target_settings,
+    )
+
+    with pytest.raises(exceptions.BadPushItem, match="Source tag v1.5 doesn't exist"):
+        tag_docker_instance.tag_remove_calculate_archs(
+            tag_docker_push_item_remove_src, "v1.8", mock_local_executor.return_value
+        )
+    mock_get_image_details.assert_called_once_with(
+        "quay.io/some-namespace/namespace----test_repo2:v1.5", mock_local_executor.return_value
+    )
+
+
 @mock.patch("pubtools._quay.tag_docker.LocalExecutor")
 @mock.patch("pubtools._quay.tag_docker.QuayClient")
 @mock.patch("pubtools._quay.tag_docker.TagDocker.get_image_details")