Fail when signature contains error (#285)

Signed-off-by: Jindrich Luza <[email protected]>

src/pubtools/_quay/signer_wrapper.py

@@ -150,6 +150,7 @@ def _sign_containers(
         )
         if signed["signer_result"]["status"] != "ok":
             raise SigningError(signed["signer_result"]["error_message"])
+
         for sign_entry in sign_entries:
             LOG.info(
                 "Signed %s(%s) with %s in %s",
@@ -314,9 +315,16 @@ def _run_store_signed(self, signed_results: Dict[str, Any]) -> None:
         LOG.info("Sending new signatures to Pyxis")
 
         signatures: List[Dict[str, Any]] = []
+        error = False
+
         for reference, op_res in zip(
             signed_results["operation"]["references"], signed_results["operation_results"]
         ):
+            if op_res[0]["msg"]["errors"]:
+                LOG.error(f"Error signing {reference}: {op_res[0]['msg']['errors']}")
+                error = True
+                continue
+
             signatures.append(
                 {
                     "manifest_digest": op_res[0]["msg"]["manifest_digest"],
@@ -326,6 +334,8 @@ def _run_store_signed(self, signed_results: Dict[str, Any]) -> None:
                     "signature_data": op_res[0]["msg"]["signed_claim"],
                 }
             )
+        if error:
+            raise SigningError("Error signing some references")
 
         for sig in signatures:
             LOG.debug(

tests/test_msg_signer.py

@@ -0,0 +1,26 @@
+import pytest
+
+from pubtools._quay.signer_wrapper import MsgSignerWrapper, SigningError
+
+
+def test_store_error_signatures(msg_signer_settings, fake_cert_key_paths, dest_manifest_list):
+    msg_signer = MsgSignerWrapper(config_file="fake-config-file", settings=msg_signer_settings)
+    with pytest.raises(SigningError):
+        msg_signer._store_signed(
+            {
+                "operation": {"references": ["fake-reference"]},
+                "operation_results": [
+                    (
+                        {
+                            "msg": {
+                                "errors": ["simulated error"],
+                                "manifest_digest": "fake-digest",
+                                "reference": "fake-reference",
+                                "repository": "fake-repo",
+                            }
+                        },
+                        None,
+                    )
+                ],
+            }
+        )