Skip to content

Stub pyi file autogen using pyo3-stub-gen #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

zao111222333
Copy link

@zao111222333 zao111222333 commented Apr 27, 2025

Follow up #237
As pyo3-stub-gen can use the pyo3's signature information for pyi file (Jij-Inc/pyo3-stub-gen#135), it will be more useful to auto generate pyi files.

Here is the new version of auto-generated egobox.pyi, by command

cargo run --package egobox --bin stub_gen

There are two tasks to be done:

BTW, thx a lot for your contribution for SMT, which I find is so efficient in my researches!

@zao111222333 zao111222333 marked this pull request as ready for review April 27, 2025 20:24
@relf
Copy link
Owner

relf commented Apr 28, 2025

Hi, thanks for your interest (you mention SMT, out of curiosity do you use GPX?).
At the moment, as discussed in #237, I prefer to wait for the update in pyo3-stub-gen before merging this.
In the meantime, I will be happy to accept a PR with just the updated egobox.pyi, thanks!

@zao111222333
Copy link
Author

you mention SMT, out of curiosity do you use GPX?

While, I have tried GPX but I found MFKPLSK is impressive accurate. GPX is good enough compared to other implementations (such as Gpy, GpyTorch) in my scenario, but MFKPLSK is the best one. (I can put my data and comparison with a colab project)
I really want to figure out MFKPLSK's mechanism, and then I can have a rust version of it.

I prefer to wait for the update in pyo3-stub-gen before merging this.
In the meantime, I will be happy to accept a PR with just the updated egobox.pyi

Fully understand, I will follow up the progress of Jij-Inc/pyo3-stub-gen#188, and if that PR spent too much time, I will create a new PR with egobox.pyi only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants