Skip to content

Add allow-popups-to-escape-sandbox to sandbox attribute of iframes #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Add allow-popups-to-escape-sandbox to sandbox attribute of iframes #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/engine/vscode/src/lib/webview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ async function getWebviewContent(url: string, profile: Profile, options: Webview
}
});

pframe.setAttribute('sandbox', 'allow-popups allow-scripts allow-same-origin allow-downloads allow-forms allow-top-navigation')
pframe.setAttribute('sandbox', 'allow-popups allow-scripts allow-same-origin allow-downloads allow-forms allow-top-navigation allow-popups-to-escape-sandbox')
pframe.setAttribute('seamless', 'true')
pframe.src = '${serverUri}?r=${Math.random()}'
pframe.setAttribute('id', 'plugin-${profile.name}')
Expand Down
2 changes: 1 addition & 1 deletion packages/engine/web/src/lib/iframe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ disconnect() {
if (this.iframe.contentWindow) {
throw new Error(`${this.name} plugin is already rendered`)
}
this.iframe.setAttribute('sandbox', 'allow-popups allow-scripts allow-same-origin allow-forms allow-top-navigation')
this.iframe.setAttribute('sandbox', 'allow-popups allow-scripts allow-same-origin allow-forms allow-top-navigation allow-popups-to-escape-sandbox')
this.iframe.setAttribute('seamless', 'true')
this.iframe.setAttribute('id', `plugin-${this.name}`)
this.iframe.src = this.url
Expand Down