Skip to content

Fix href function return empty string #13613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix href function return empty string #13613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87db12c
Fix href function return empty string
gelove May 15, 2025
70f2c93
Fix href function return empty string
gelove May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@
- gatzjames
- gavriguy
- Geist5000
- gelove
- gesposito
- gianlucca
- gijo-varghese
Expand Down
5 changes: 4 additions & 1 deletion packages/react-router/lib/href.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ type ToArgs<T> =
Returns a resolved URL path for the specified route.

```tsx
const h = href("/:lang?", {})
// -> `/`

const h = href("/:lang?/about", { lang: "en" })
// -> `/en/about`

Expand Down Expand Up @@ -51,5 +54,5 @@ export function href<Path extends keyof Args>(
return value;
})
.filter((segment) => segment !== undefined)
.join("/");
.join("/") || "/";
}