Add states natively to execution monad #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tperami
reviewed
Mar 21, 2025
| @@ -70,6 +70,10 @@ Proof. tcclean. unfold mret, list_ret. set_solver. Qed. | |||
|
|
|||
| #[export] Instance list_elements {A} : Elements A (list A) := λ x, x. | |||
|
|
|||
| #[global] Instance cdestruct_list_elements b {A} x (l : list A) : | |||
There was a problem hiding this comment.
This is already in the set unfold instances, is there a particular reason to use this instance instead? Also please don't use global
| @@ -234,16 +234,17 @@ Module GenPromising (IWA : InterfaceWithArch) (TM : TermModelsT IWA). | |||
| (** Check if all threads have no outstanding promises *) | |||
| Definition nopromises (ps : t) := fforallb (nopromises_tid ps). | |||
|
|
|||
| (* Definition liftSt {St St' E A} (getter : St → St') `{Setter St St' getter} (inner : Exec.t St' E A) : Exec.t St E A. *) | |||
There was a problem hiding this comment.
This should not be still here
| : Exec.t string t := | ||
| ev ← promise_select_tid fuel st tid; | ||
| mret $ promise_tid isem prom st tid ev. | ||
| Program Definition cpromise_tid (fuel : nat) (tid : fin n) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still very much unfinished. I never fully fixed up the promising part. Also I need to clean up the Exec.v file: Make res/t record visually more separated, use Exec.res monadic operations in Exec.t.