Fix crash on high debug #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cerb_frontend.Pp_symbol.to_string_pretty_cn was updated to (a)
not depend at all on the Cerberus debug level to decide whether or not
to print symbols with an "_{<num>}" suffix, and 9b) take an optional
named argument to control that instead.
This commit updates the CN usage of that API, and fixes a solver crash
in doing so. This is because the SMTLib2 simple-symbol token does not
accept braces as part of symbol names (it does as part of names quoted
with a |_| but that would have made the SMT output more noisy and harder
to read or the code more complex to check whether to escape or not).
It does so by using a separate API which never prints the
number-in-braces prefix for the uses in the solver, even if the flag for
doing so is set for CN.
It also does the same for auto-generated variables for unpacking
predicates and function calls, created in check.ml/typing.ml.
I also suspect a similar bug may affect the Coq output, and so that too
will be changed.
Not clear if this makes a observale difference with the current features but it reduces the frontend API exposure surface.
dc-mak
force-pushed
the
fix-crash-on-high-debug
branch
from
d7880f0 to
9598b4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.