-
Notifications
You must be signed in to change notification settings - Fork 122
Add WalletGuide submission item to WalletKit best practices checklist #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WalletGuide submission item to WalletKit best practices checklist #517
Conversation
- Added new checklist item 6 for WalletGuide submission - Links to existing explorer submission documentation - Helps wallet developers get listed in WalletGuide - Follows existing checklist format and structure Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new checklist item to the WalletKit best practices documentation to encourage wallet developers to submit their wallets to WalletGuide, helping ensure they are listed in the explorer.
- Added checklist item 6 ("WalletGuide Submission") with three detailed sub-bullets
- Includes a link to the comprehensive explorer submission documentation for further guidance
| - ✅ Ensure that you are using the latest SDK version | ||
| - ✅ Update your SDK regularly to benefit from the latest features and bug fixes | ||
| - ✅ Subscribe to SDK updates to stay informed about new releases | ||
| 6. **WalletGuide Submission** |
Copilot
AI
Jun 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider whether maintaining manual numbering in the checklist is ideal. Automating numbering or using a consistent list style could ease future updates and reduce the risk of numbering errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot open a new pull request to apply changes based on this feedback
|
❌ Cannot revive Devin session - the session is too old. Please start a new session instead. |
|
@rohit-710 I've opened a new pull request, #680, to work on those changes. Once the pull request is ready, I'll request review from you. |
Add WalletGuide submission item to WalletKit best practices checklist
Summary
Added a new checklist item (#6) to the "Checklist Before Going Live" section in the WalletKit best practices documentation. This addresses the gap identified where wallet developers weren't being reminded to submit their wallets to WalletGuide for listing. The new item links to existing comprehensive explorer submission documentation and follows the same format as other checklist items.
Key Changes:
../cloud/explorer-submissionfor detailed submission instructionsReview & Testing Checklist for Human
../cloud/explorer-submissionworks correctly from the deployed WalletKit best practices page and navigates to the proper explorer submission documentationDiagram
graph TD A[walletkit/best-practices.mdx]:::major-edit --> B[Checklist Before Going Live Section] B --> C[Item 1: Success/Error Messages]:::context B --> D[Item 2: Mobile Linking]:::context B --> E[Item 3: Latency]:::context B --> F[Item 4: Verify API]:::context B --> G[Item 5: Latest SDK Version]:::context B --> H[Item 6: WalletGuide Submission]:::major-edit H --> I[cloud/explorer-submission.mdx]:::context I --> J[WalletGuide Listing Process]:::context subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
pnpm dev- documentation renders correctly and link navigation works