Add WalletGuide submission item to WalletKit best practices checklist #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Added new checklist item 6 for WalletGuide submission - Links to existing explorer submission documentation - Helps wallet developers get listed in WalletGuide - Follows existing checklist format and structure Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new checklist item to the WalletKit best practices documentation to encourage wallet developers to submit their wallets to WalletGuide, helping ensure they are listed in the explorer.
- Added checklist item 6 ("WalletGuide Submission") with three detailed sub-bullets
- Includes a link to the comprehensive explorer submission documentation for further guidance
| @@ -46,6 +46,10 @@ To make sure your wallet adheres to the best practices, we recommend implementin | |||
| - ✅ Ensure that you are using the latest SDK version | |||
| - ✅ Update your SDK regularly to benefit from the latest features and bug fixes | |||
| - ✅ Subscribe to SDK updates to stay informed about new releases | |||
| 6. **WalletGuide Submission** | |||
There was a problem hiding this comment.
[nitpick] Consider whether maintaining manual numbering in the checklist is ideal. Automating numbering or using a consistent list style could ease future updates and reduce the risk of numbering errors.
Copilot uses AI. Check for mistakes.
Naratp
approved these changes
Jun 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WalletGuide submission item to WalletKit best practices checklist
Summary
Added a new checklist item (#6) to the "Checklist Before Going Live" section in the WalletKit best practices documentation. This addresses the gap identified where wallet developers weren't being reminded to submit their wallets to WalletGuide for listing. The new item links to existing comprehensive explorer submission documentation and follows the same format as other checklist items.
Key Changes:
../cloud/explorer-submissionfor detailed submission instructionsReview & Testing Checklist for Human
../cloud/explorer-submissionworks correctly from the deployed WalletKit best practices page and navigates to the proper explorer submission documentationDiagram
graph TD A[walletkit/best-practices.mdx]:::major-edit --> B[Checklist Before Going Live Section] B --> C[Item 1: Success/Error Messages]:::context B --> D[Item 2: Mobile Linking]:::context B --> E[Item 3: Latency]:::context B --> F[Item 4: Verify API]:::context B --> G[Item 5: Latest SDK Version]:::context B --> H[Item 6: WalletGuide Submission]:::major-edit H --> I[cloud/explorer-submission.mdx]:::context I --> J[WalletGuide Listing Process]:::context subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
pnpm dev- documentation renders correctly and link navigation works