Skip to content

Bugfix: fix crash when put with the same id repeatly when use use concurrency and max > 1 #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bugfix: fix crash when put with the same id repeatly when use use concurrency and max > 1 #2458

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa25d22
Bugfix: fix crash when put with the same id repeatly when use concurr…
Jul 9, 2025
368539f
Merge branch 'main' into async_put_twice
sinopec Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions python/cog/server/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,16 @@ async def predict_idempotent(
jsonable_encoder(task.result),
status_code=202,
)
else:
# even if not busy (use concurrency and max > 1) ,
# but someone put with the same prediction id repeatedly ,
# return its current state.
task = runner.get_predict_task(request.id)
if task:
return JSONResponse(
jsonable_encoder(task.result),
status_code=202,
)

# TODO: spec-compliant parsing of Prefer header.
respond_async = prefer == "respond-async"
Expand Down