Pass if clock is synced even if ntp is inactive (#1893)

replicatedhq · Feb 18, 2025 · ccf5a68 · ccf5a68
1 parent 0ac84ec
commit ccf5a68
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/cmd/installer/goods/support/host-support-bundle.tmpl.yaml b/cmd/installer/goods/support/host-support-bundle.tmpl.yaml
@@ -431,6 +431,9 @@ spec:
         - fail:
             when: 'ntp == unsynchronized+active'
             message: NTP is enabled but the system clock is not synchronized. Synchronize the system clock to continue.
+        - pass:
+            when: 'ntp == synchronized+inactive' # don't fail as the system clock might be managed by other protocols (e.g. PTP)
+            message: NTP is inactive but the system clock is synchronized
         - pass:
             when: 'ntp == synchronized+active'
             message: NTP is enabled and the system clock is synchronized

diff --git a/pkg/preflights/host-preflight.yaml b/pkg/preflights/host-preflight.yaml
@@ -232,9 +232,14 @@ spec:
           - fail:
               when: 'ntp == unsynchronized+active'
               message: NTP is enabled but the system clock is not synchronized. Synchronize the system clock to continue.
+          - pass:
+              when: 'ntp == synchronized+inactive' # don't fail as the system clock might be managed by other protocols (e.g. PTP)
+              message: NTP is inactive but the system clock is synchronized
           - pass:
               when: 'ntp == synchronized+active'
               message: NTP is enabled and the system clock is synchronized
+          - fail:
+              message: 'Unable to determine system clock status'
     - jsonCompare:
         checkName: Cgroups
         fileName: host-collectors/system/cgroups.json