Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add default fail outcome if ntp status is unknown #1771

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Jan 30, 2025

What this PR does / why we need it:

Add a default fail message to system clock host preflight.

Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?


Does this PR require documentation?

@banjoh banjoh marked this pull request as draft January 30, 2025 14:19
Copy link

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-a53d935" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-a53d935?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

@banjoh banjoh marked this pull request as ready for review February 17, 2025 18:45
@sgalsaleh
Copy link
Member

Closed in favor of #1893

@sgalsaleh sgalsaleh closed this Feb 18, 2025
@sgalsaleh sgalsaleh deleted the evansmungai/sc-119141/add-fail-case-for-ec-host-pre-flight-check branch February 18, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants