chore: remove dead code #1814
Merged
chore: remove dead code #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emosbaugh
commented
Feb 5, 2025
pkg/configutils/kots.go
Outdated
| } | ||
|
|
||
| // ValidateKotsConfigValues checks if the file exists and has the 'kots.io/v1beta1 ConfigValues' GVK | ||
| func ValidateKotsConfigValues(filename string) error { |
emosbaugh
commented
Feb 5, 2025
Comment on lines
-73
to
-74
| isAutoSelectedNetworkInterface bool | ||
| autoSelectNetworkInterfaceErr error |
emosbaugh
force-pushed
the
emosbaugh/20250205/remove-dead-code
branch
from
a66c64d to
d4740f0
Compare
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
sgalsaleh
previously approved these changes
Feb 5, 2025
sgalsaleh
reviewed
Feb 5, 2025
cmd/buildtools/addon.go
Outdated
| @@ -20,10 +20,8 @@ type addonComponent struct { | |||
| } | |||
|
|
|||
| type addonComponentOptions struct { | |||
| ctx context.Context | |||
| k0sVersion *semver.Version | |||
There was a problem hiding this comment.
i need this in a pr i'm working on...
sgalsaleh
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?