Feat/on chain redemptions #1163
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think that's exactly the right approach -- we can deploy this contract and hook our Facade to point to it. I'm going to hold off until the rETH-trading case is in the contract but this sounds like the plan for after. |
jankjr
force-pushed
the
feat/on-chain-redemptions
branch
from
f17d084 to
d3569b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure where this would fit in so i'm pushing it here for now.
This script will redeem ETH+ directly for ETH and follows an interview that mimicks uniswap v2. It only works for ETH+ into ETH, it actually performs relatively well for smaller amounts at least ignoring gas costs.
Perhaps this could make a sort of routers part of the
Facade, and add a few predefined and maintained ways to exit an RToken position into a single underlying? @tbrent